Diagnostic messages.

Diagnostic messages.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a6e0ecb30a83b6f6daf1314f54fc5269b5f45db7

[ahe, 2017-03-17 15:59:35]

ahe@google.com changed reviewers:
+ sigmund@google.com

[ahe, 2017-03-17 15:59:36]

I've gathered these diagnostic messages from various sources:

* pkg/compiler/lib/src/diagnostics/messages.dart

* pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart

* pkg/compiler/lib/src/parser/element_listener.dart

Long term, I want to align this with pkg/dart_messages/lib/shared_messages.dart
and the analyzer's messages. But short term, I'd like better messages in Fasta.

I've found that specifying diagnostic messages in Dart files to be too
cumbersome, and YAML seems like a much better fit.

If we can agree on this overall approach, I'd like to follow this CL up with
some tools that read the YAML file and generates Dart files: one for testing,
and one for printing messages in Fasta.

There's a lot of additional information we could and should add to this format,
especially unique error codes, however, I'd prefer if someone else could take a
lead on that. This is just a meager start, not the finished product.

[Siggi Cherem (dart-lang), 2017-03-17 21:48:34]

lgtm

I like the general direction of making our specification in .yaml. Sounds good
to start with something we can use in fasta and grow from there.

https://codereview.chromium.org/2756923002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2756923002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:13: #    declaration, member, script, or bytes).
do we want to also specify upfront the kind (error, warning, hint)?

how about some kind of grouping or flag to denote which messages were introduced
with strong-mode?

[ahe, 2017-03-22 11:04:26]

https://codereview.chromium.org/2756923002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2756923002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:13: #    declaration, member, script, or bytes).
On 2017/03/17 21:48:34, Siggi Cherem (dart-lang) wrote:
> do we want to also specify upfront the kind (error, warning, hint)?
> 
> how about some kind of grouping or flag to denote which messages were
introduced
> with strong-mode?

I like the idea of grouping messages. Some messages can both be warnings and
errors. But perhaps that can be a special group. I'll add some comments about
that in another CL.

[ahe, 2017-03-22 11:23:20]

Description was changed from

==========
Diagnostic messages.
==========

to

==========
Diagnostic messages.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a6e0ecb30a83b6f6daf1314f54fc5269b5f45db7
==========

[ahe, 2017-03-22 11:23:22]

Committed patchset #1 (id:1) manually as
a6e0ecb30a83b6f6daf1314f54fc5269b5f45db7 (presubmit successful).