Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2754783004: Add UseCounters to evaluate usage and risk with upcoming WebVR spec changes. (Closed)

Created:
3 years, 9 months ago by billorr
Modified:
3 years, 9 months ago
Reviewers:
xhwang
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Add UseCounters to evaluate usage and risk with upcoming WebVR spec changes. BUG=701525 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2747803005 Cr-Commit-Position: refs/heads/master@{#457176} (cherry picked from commit 8fd773268f69e868b3f57b90708709c4b085e9cb) Review-Url: https://codereview.chromium.org/2754783004 Cr-Commit-Position: refs/branch-heads/3029@{#250} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/75ce6202acc3ef49f9c7c504c26b8f5805da97a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplayCapabilities.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VREyeParameters.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRPose.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754783004/1
3 years, 9 months ago (2017-03-16 23:17:21 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-16 23:17:23 UTC) #4
xhwang
rs lgtm!
3 years, 9 months ago (2017-03-16 23:18:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754783004/1
3 years, 9 months ago (2017-03-16 23:19:49 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-03-16 23:19:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754783004/1
3 years, 9 months ago (2017-03-16 23:21:48 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 23:28:34 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75ce6202acc3ef49f9c7c504c26b...

Powered by Google App Engine
This is Rietveld 408576698