Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2747803005: Add UseCounters to evaluate usage and risk with upcoming WebVR spec changes. (Closed)

Created:
3 years, 9 months ago by billorr
Modified:
3 years, 9 months ago
Reviewers:
bokan, bajones, jwd
CC:
chromium-reviews, blink-reviews, haraken, amp, ddorwin, blink-reviews-frames_chromium.org, feature-vr-reviews_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounters to evaluate usage and risk with upcoming WebVR spec changes. BUG=701525 Review-Url: https://codereview.chromium.org/2747803005 Cr-Commit-Position: refs/heads/master@{#457176} Committed: https://chromium.googlesource.com/chromium/src/+/8fd773268f69e868b3f57b90708709c4b085e9cb

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplayCapabilities.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VREyeParameters.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRPose.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
billorr
bajones@chromium.org: Please review changes in modules/vr bokan@chromium.org: Please review changes in UseCounter.h jwd@chromium.org: Please review ...
3 years, 9 months ago (2017-03-14 21:34:29 UTC) #2
bokan
UseCounter.h lgtm
3 years, 9 months ago (2017-03-14 21:38:27 UTC) #3
bajones
LGTM
3 years, 9 months ago (2017-03-14 22:18:17 UTC) #4
jwd
lgtm
3 years, 9 months ago (2017-03-15 14:51:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747803005/1
3 years, 9 months ago (2017-03-15 16:12:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/386140) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-15 16:19:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747803005/20001
3 years, 9 months ago (2017-03-15 18:04:31 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 19:56:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8fd773268f69e868b3f57b907087...

Powered by Google App Engine
This is Rietveld 408576698