Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2754523004: Remove dynamic MediaControlCastButtonElement::shadowPseudoId. (Closed)

Created:
3 years, 9 months ago by esprehn
Modified:
3 years, 9 months ago
Reviewers:
nainar, rune
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dynamic MediaControlCastButtonElement::shadowPseudoId. The m_isOverlayButton bit is never set dynamically, and even if it was it wouldn't work right unless we forced a style recalc at the same time to make sure we rematched the style with the new pseudo value. Instead of having this virtual override lets just use the default one and set the pseudo attribute when the element is created. BUG=701655 Review-Url: https://codereview.chromium.org/2754523004 Cr-Commit-Position: refs/heads/master@{#457014} Committed: https://chromium.googlesource.com/chromium/src/+/91afacdd96a5d1ca0a0e3235bc62526834a67463

Patch Set 1 #

Patch Set 2 : Modify attrs after constructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 1 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
esprehn
3 years, 9 months ago (2017-03-15 06:06:51 UTC) #4
nainar
lgtm
3 years, 9 months ago (2017-03-15 06:23:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754523004/20001
3 years, 9 months ago (2017-03-15 06:24:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/91afacdd96a5d1ca0a0e3235bc62526834a67463
3 years, 9 months ago (2017-03-15 06:32:39 UTC) #11
rune
3 years, 9 months ago (2017-03-15 08:36:00 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698