Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Issue 2754523004: Remove dynamic MediaControlCastButtonElement::shadowPseudoId. (Closed)
Patch Set: Modify attrs after constructor. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 316
317 bool hasOverflowButton() override { return true; } 317 bool hasOverflowButton() override { return true; }
318 318
319 // This will show a cast button if it is not covered by another element. 319 // This will show a cast button if it is not covered by another element.
320 // This MUST be called for cast button elements that are overlay elements. 320 // This MUST be called for cast button elements that are overlay elements.
321 void tryShowOverlay(); 321 void tryShowOverlay();
322 322
323 private: 323 private:
324 explicit MediaControlCastButtonElement(MediaControls&, bool isOverlayButton); 324 explicit MediaControlCastButtonElement(MediaControls&, bool isOverlayButton);
325 325
326 const AtomicString& shadowPseudoId() const override;
327 void defaultEventHandler(Event*) override; 326 void defaultEventHandler(Event*) override;
328 bool keepEventInNode(Event*) override; 327 bool keepEventInNode(Event*) override;
329 328
330 bool m_isOverlayButton; 329 bool m_isOverlayButton;
331 330
332 // This is used for UMA histogram (Cast.Sender.Overlay). New values should 331 // This is used for UMA histogram (Cast.Sender.Overlay). New values should
333 // be appended only and must be added before |Count|. 332 // be appended only and must be added before |Count|.
334 enum class CastOverlayMetrics { 333 enum class CastOverlayMetrics {
335 Created = 0, 334 Created = 0,
336 Shown, 335 Shown,
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 public: 379 public:
381 static MediaControlCurrentTimeDisplayElement* create(MediaControls&); 380 static MediaControlCurrentTimeDisplayElement* create(MediaControls&);
382 381
383 private: 382 private:
384 explicit MediaControlCurrentTimeDisplayElement(MediaControls&); 383 explicit MediaControlCurrentTimeDisplayElement(MediaControls&);
385 }; 384 };
386 385
387 } // namespace blink 386 } // namespace blink
388 387
389 #endif // MediaControlElements_h 388 #endif // MediaControlElements_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698