Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2754413002: Disable ERROR logging for the valid case in app list sync service. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ERROR logging for the valid case in app list sync service. This changes ERROR logging to VERBOSE logging case, which is actually valid. This should reduce noise in users' feedbacks. BUG=701039 TEST=Manually, detected cases causing such error message. Review-Url: https://codereview.chromium.org/2754413002 Cr-Commit-Position: refs/heads/master@{#457902} Committed: https://chromium.googlesource.com/chromium/src/+/1852c3e4976e2ac0473350f8aa4589e753926934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
khmel
Hi Steven, PTAL Thanks!
3 years, 9 months ago (2017-03-17 21:59:00 UTC) #3
stevenjb
Thanks! lgtm.
3 years, 9 months ago (2017-03-17 22:00:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754413002/1
3 years, 9 months ago (2017-03-17 22:01:45 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 23:27:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1852c3e4976e2ac0473350f8aa45...

Powered by Google App Engine
This is Rietveld 408576698