Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/browser/ui/app_list/app_list_syncable_service.cc

Issue 2754413002: Disable ERROR logging for the valid case in app list sync service. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_list_syncable_service.cc
diff --git a/chrome/browser/ui/app_list/app_list_syncable_service.cc b/chrome/browser/ui/app_list/app_list_syncable_service.cc
index 2629e1676a8cd8fa31dd3c3956de228267dc243c..a9ea88b5092a6496740f708b3680d66d7f5cf850 100644
--- a/chrome/browser/ui/app_list/app_list_syncable_service.cc
+++ b/chrome/browser/ui/app_list/app_list_syncable_service.cc
@@ -1025,7 +1025,11 @@ void AppListSyncableService::ProcessExistingSyncItem(SyncItem* sync_item) {
AppListItem* app_item = model_->FindItem(sync_item->item_id);
DVLOG(2) << " AppItem: " << app_item->ToDebugString();
if (!app_item) {
- LOG(ERROR) << "Item not found in model: " << sync_item->ToString();
+ // This is expected in case the user uses devices with different app set,
+ // for example, ARC enabled and ARC disabled devices. Another scenario is
+ // app pinned by default (YouTube, for instance) but which has not been yet
+ // installed on this device.
+ DVLOG(2) << "Skip updating missing item : " << sync_item->ToString();
return;
}
// This is the only place where sync can cause an item to change folders.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698