Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2754393002: [wasm] re-enable simd-scalar-lowering tests (Closed)

Created:
3 years, 9 months ago by aseemgarg
Modified:
3 years, 9 months ago
Reviewers:
bbudge
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] re-enable simd-scalar-lowering tests R=bbudge@chromium.org BUG=v8:6020 Review-Url: https://codereview.chromium.org/2754393002 Cr-Commit-Position: refs/heads/master@{#43918} Committed: https://chromium.googlesource.com/v8/v8/+/931714675b3ac323d7121e275c4fe7ff32f59eec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/cctest/wasm/test-run-wasm-simd.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
aseemgarg
3 years, 9 months ago (2017-03-17 19:19:44 UTC) #1
bbudge
lgtm
3 years, 9 months ago (2017-03-17 20:16:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754393002/1
3 years, 9 months ago (2017-03-17 20:16:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/931714675b3ac323d7121e275c4fe7ff32f59eec
3 years, 9 months ago (2017-03-17 20:46:16 UTC) #7
aseemgarg
3 years, 9 months ago (2017-03-17 22:06:09 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2749023010/ by aseemgarg@chromium.org.

The reason for reverting is: Seems like this is breaking V8 Linux - arm64 - sim
- MSAN.

Powered by Google App Engine
This is Rietveld 408576698