Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2754133002: Remove gesture token from vrdisplayactivate (Closed)

Created:
3 years, 9 months ago by mthiesse
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Remove gesture token from vrdisplayactivate Adds a specific exception to the user gesture requirement for presentation when presenting during a vrdisplayactivate event, and removes the generic user gesture from vrdisplayactivate. BUG=701429 Review-Url: https://codereview.chromium.org/2751753003 Cr-Commit-Position: refs/heads/master@{#456797} (cherry picked from commit bcba8c8b526a9476f40f3830b3daabac7812bbcc) Review-Url: https://codereview.chromium.org/2754133002 . Cr-Commit-Position: refs/branch-heads/3029@{#246} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/57bfb0bcbbc513726876f0bb55692d168aa662bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M third_party/WebKit/Source/modules/vr/NavigatorVR.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
mthiesse
Committed patchset #1 (id:1) manually as 57bfb0bcbbc513726876f0bb55692d168aa662bc.
3 years, 9 months ago (2017-03-16 18:40:10 UTC) #2
mthiesse
3 years, 9 months ago (2017-03-16 21:53:53 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2756033002/ by mthiesse@chromium.org.

The reason for reverting is: Fails to compile on M58 due to removing a header
that was still used..

Powered by Google App Engine
This is Rietveld 408576698