Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2751753003: Remove gesture token from vrdisplayactivate (Closed)

Created:
3 years, 9 months ago by mthiesse
Modified:
3 years, 9 months ago
Reviewers:
bajones
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gesture token from vrdisplayactivate Adds a specific exception to the user gesture requirement for presentation when presenting during a vrdisplayactivate event, and removes the generic user gesture from vrdisplayactivate. BUG=701429 Review-Url: https://codereview.chromium.org/2751753003 Cr-Commit-Position: refs/heads/master@{#456797} Committed: https://chromium.googlesource.com/chromium/src/+/bcba8c8b526a9476f40f3830b3daabac7812bbcc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M third_party/WebKit/Source/modules/vr/NavigatorVR.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL
3 years, 9 months ago (2017-03-14 17:51:02 UTC) #2
bajones
LGTM, Thanks!
3 years, 9 months ago (2017-03-14 17:59:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751753003/1
3 years, 9 months ago (2017-03-14 18:00:07 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 19:54:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bcba8c8b526a9476f40f3830b3da...

Powered by Google App Engine
This is Rietveld 408576698