Format all dart: library files

Format all dart: library files

BUG=
R=floitsch@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/ea6991a245463f6b31e3f930ea5ec495447a5d4a

[Jacob, 2017-03-16 03:28:21]

jacobr@google.com changed reviewers:
+ alanknight@google.com, floitsch@google.com

[Jacob, 2017-03-16 03:28:23]

Alan for the dart:html files
Florian for all other dart: files

Alan I'd suggest we run dartfmt manually after running
the dart:html generation scripts or add running dartfmt
directly to the dart:html build script.

Generally these formatting changes look reasonable it will make everyone more
productive going forward as after making changes you will be able to run dartfmt
to ensure
your code is formatted correctly without creating spurious diffs.

[sra1, 2017-03-16 03:50:49]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-03-16 03:50:50]

js_runtime lgtm

[floitsch, 2017-03-16 10:37:55]

LGTM except for the following files:
- uri.dart
- base64.dart
- internal.dart
- crypto.dart
- http_parser.dart

Some of them are destroying comments. Some are making it significantly harder to
understand the constants. Some are just really bad (because too long).

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/convert/base64.dart
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/convert/base64.dart...
sdk/lib/convert/base64.dart:518: __,
There is a reason these were aligned in blocks of 16.

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:2852: //             LSB            MSB
This completely destroys the meaning of the comments.

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/internal/internal.dart
File sdk/lib/internal/internal.dart (right):

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/internal/internal.d...
sdk/lib/internal/internal.dart:24: /*  0 */
Comments are not saying the same thing anymore.

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/io/crypto.dart
File sdk/lib/io/crypto.dart (right):

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/io/crypto.dart#newc...
sdk/lib/io/crypto.dart:25: -2,
There was a reason these were aligned in blocks of 16.

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/2754013002/diff/1/sdk/lib/io/http_parser.dart...
sdk/lib/io/http_parser.dart:22: F,
This really makes reading this file harder.

[Jacob, 2017-03-16 17:22:33]

Description was changed from

==========
Format all dart: library files

BUG=
==========

to

==========
Format all dart: library files

BUG=
R=floitsch@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ea6991a245463f6b31e3f930ea5ec495447a5d4a
==========

[Jacob, 2017-03-16 17:22:35]

Committed patchset #2 (id:10001) manually as
ea6991a245463f6b31e3f930ea5ec495447a5d4a (presubmit successful).

[Alan Knight, 2017-03-17 19:19:06]

Doing this for the html-related libraries is kind of pointless, since the next
time those are regenerated they'll be overwritten. It would be better to
introduce a formatting step into the generation, but that might also wait until
the next Dartium roll lands.