mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl - Issue 2754003005: Mojo C++ Bindings: fix mojom::Foo::Deserialize() for component build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

Issue 2754003005: Mojo C++ Bindings: fix mojom::Foo::Deserialize() for component build. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/test_export2.mojom ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

index 9e6e46f19e66cc6021ebf26d77eae107333c49f1..7ad9b4e1bc3b2dc5ede948c53c3b0daff86cfd77 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

@@ -73,7 +73,7 @@ class {{export_attribute}} {{struct.name}} {

UserType* output) {

return mojo::internal::StructDeserializeImpl<

{{struct.name}}::DataView, {{serialization_result_type}}>(

- input, output);

+ input, output, Validate);

}

{#--- Struct members #}

@@ -83,8 +83,11 @@ class {{export_attribute}} {{struct.name}} {

{{type}} {{name}};

{%- endfor %}

-{%- if struct|contains_move_only_members %}

private:

+ static bool Validate(const void* data,

+ mojo::internal::ValidationContext* validation_context);

+{%- if struct|contains_move_only_members %}

DISALLOW_COPY_AND_ASSIGN({{struct.name}});

{%- endif %}

};