Disable FileReaderSync in service workers.

Disable FileReaderSync in service workers.

Usage so far in service workers is zero, so go ahead with disabling
FileReaderSync in service workers as planned.

Intent to deprecate and remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/cjWtqRD6iw8/hcxtAeE2CAAJ

BUG=688586
Review-Url: https://codereview.chromium.org/2753943002
Cr-Commit-Position: refs/heads/master@{#458487}
Committed: https://chromium.googlesource.com/chromium/src/+/2a0319f1e13c5d4f7e8eb7771a8818f31a951b01

[Marijn Kruisselbrink, 2017-03-15 21:25:58]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 21:26:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 23:07:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:07:16]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Marijn Kruisselbrink, 2017-03-15 23:12:29]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 23:13:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:34:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marijn Kruisselbrink, 2017-03-16 17:40:13]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 17:41:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-03-16 18:36:37]

mek@chromium.org changed reviewers:
+ foolip@chromium.org

[commit-bot: I haz the power, 2017-03-16 20:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 20:14:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marijn Kruisselbrink, 2017-03-17 18:29:27]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 18:30:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-03-17 18:32:29]

Patchset #4 (id:60001) has been deleted

[Marijn Kruisselbrink, 2017-03-17 18:33:18]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 18:34:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 20:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 20:05:30]

Dry run: This issue passed the CQ dry run.

[Marijn Kruisselbrink, 2017-03-20 16:49:20]

foolip: ping?

[foolip, 2017-03-21 09:00:02]

lgtm

https://codereview.chromium.org/2753943002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp (left):

https://codereview.chromium.org/2753943002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp:59:
UseCounter::FileReaderSyncInServiceWorker);
Can you remove the entry from UseCounter.h as well?

[Marijn Kruisselbrink, 2017-03-21 16:32:51]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 16:33:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-03-21 17:04:17]

https://codereview.chromium.org/2753943002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp (left):

https://codereview.chromium.org/2753943002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp:59:
UseCounter::FileReaderSyncInServiceWorker);
On 2017/03/21 at 09:00:02, foolip_UTC9 wrote:
> Can you remove the entry from UseCounter.h as well?

Done

[Marijn Kruisselbrink, 2017-03-21 17:04:25]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2017-03-21 17:04:27]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2017-03-21 17:04:27]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2753943002/#ps100001
(title: "remove entry from UseCounter.h as well")

[commit-bot: I haz the power, 2017-03-21 17:04:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:40:04]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490115867047740,
"parent_rev": "3fbc8b7641ee4665f400dee3641e7362b581d09a", "commit_rev":
"2a0319f1e13c5d4f7e8eb7771a8818f31a951b01"}

[commit-bot: I haz the power, 2017-03-21 18:40:53]

Description was changed from

==========
Disable FileReaderSync in service workers.

Usage so far in service workers is zero, so go ahead with disabling
FileReaderSync in service workers as planned.

Intent to deprecate and remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/cjWtqRD6iw8/hcxtAeE2...

BUG=688586
==========

to

==========
Disable FileReaderSync in service workers.

Usage so far in service workers is zero, so go ahead with disabling
FileReaderSync in service workers as planned.

Intent to deprecate and remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/cjWtqRD6iw8/hcxtAeE2...

BUG=688586

Review-Url: https://codereview.chromium.org/2753943002
Cr-Commit-Position: refs/heads/master@{#458487}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a0319f1e13c5d4f7e8eb7771a88...
==========

[commit-bot: I haz the power, 2017-03-21 18:40:55]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2a0319f1e13c5d4f7e8eb7771a88...