Disable FileReaderSync in service workers.

third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp

 /*
  * Copyright (C) 2010 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #include "core/fileapi/FileReaderSync.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "core/dom/DOMArrayBuffer.h"
 #include "core/fileapi/Blob.h"
 #include "core/fileapi/FileError.h"
 #include "core/fileapi/FileReaderLoader.h"
-#include "core/frame/Deprecation.h"
 #include "platform/Histogram.h"
 
 namespace blink {
 
 namespace {
 // These values are written to logs.  New enum values can be added, but existing
 // enums must never be renumbered or deleted and reused.
 enum class WorkerType {
   OTHER = 0,
   DEDICATED_WORKER = 1,
   SHARED_WORKER = 2,
   SERVICE_WORKER = 3,
   MAX
 };
 }  // namespace
 
 FileReaderSync::FileReaderSync(ExecutionContext* context) {
-  if (context->isServiceWorkerGlobalScope()) {
-    Deprecation::countDeprecation(context,
-                                  UseCounter::FileReaderSyncInServiceWorker);

[foolip, 2017/03/21 09:00:02]

Can you remove the entry from UseCounter.h as well?

[Marijn Kruisselbrink, 2017/03/21 17:04:17]

Done

-  }
-
   WorkerType type = WorkerType::OTHER;
   if (context->isDedicatedWorkerGlobalScope())
     type = WorkerType::DEDICATED_WORKER;
   else if (context->isSharedWorkerGlobalScope())
     type = WorkerType::SHARED_WORKER;
   else if (context->isServiceWorkerGlobalScope())
     type = WorkerType::SERVICE_WORKER;
   DEFINE_THREAD_SAFE_STATIC_LOCAL(
       EnumerationHistogram, workerTypeHistogram,
       new EnumerationHistogram("FileReaderSync.WorkerType",
@@ skipping 57 matching lines @@
 void FileReaderSync::startLoading(ExecutionContext* executionContext,
                                   FileReaderLoader& loader,
                                   const Blob& blob,
                                   ExceptionState& exceptionState) {
   loader.start(executionContext, blob.blobDataHandle());
   if (loader.errorCode())
     FileError::throwDOMException(exceptionState, loader.errorCode());
 }
 
 }  // namespace blink