Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2753903004: MIPS[64]: Support for some SIMD operations (Closed)

Created:
3 years, 9 months ago by dusan.simicic
Modified:
3 years, 8 months ago
Reviewers:
ivica.bogosavljevic, bbudge, Mircea Trofin, v8-mips-ports, miran.karic, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Support for some SIMD operations Adds support for I32x4Splat, I32x4ExtractLane, I32x4ReplaceLane, I32x4Add, I32x4Sub, S128Zero operations for mips32 and mips64 architectures. BUG= Note: Depends on patch: https://codereview.chromium.org/2740123004/ Review-Url: https://codereview.chromium.org/2753903004 Cr-Commit-Position: refs/heads/master@{#44326} Committed: https://chromium.googlesource.com/v8/v8/+/12faf0f87f0d180abdfe294f6646bbf2044789e8

Patch Set 1 #

Patch Set 2 : Replaced copy_u_w with copy_s_w for kMips[64]Int32x4ExtractLane #

Patch Set 3 : Fixed Int32x4ReplaceLane #

Patch Set 4 : Fixed Int32x4ReplaceLane #

Total comments: 2

Patch Set 5 : removed comment in test-run-wasm-simd.cc #

Patch Set 6 : patch rebased #

Patch Set 7 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -9 lines) Patch
M src/compiler/instruction-selector.cc View 1 2 3 4 5 6 4 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 3 4 5 1 chunk +39 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 2 3 4 5 1 chunk +7 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 4 5 6 2 chunks +56 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 3 4 5 1 chunk +39 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 2 3 4 5 1 chunk +7 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 3 4 5 6 2 chunks +56 lines, -0 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 36 (23 generated)
dusan.simicic
PTAL
3 years, 9 months ago (2017-03-17 14:09:17 UTC) #2
ivica.bogosavljevic
lgtm
3 years, 9 months ago (2017-03-21 10:45:27 UTC) #3
dusan.simicic
+titzer, +bbudge
3 years, 9 months ago (2017-03-27 13:30:18 UTC) #5
bbudge
lgtm https://codereview.chromium.org/2753903004/diff/60001/test/cctest/wasm/test-run-wasm-simd.cc File test/cctest/wasm/test-run-wasm-simd.cc (right): https://codereview.chromium.org/2753903004/diff/60001/test/cctest/wasm/test-run-wasm-simd.cc#newcode39 test/cctest/wasm/test-run-wasm-simd.cc:39: #endif // !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_IA32 nit: ...
3 years, 9 months ago (2017-03-27 17:12:03 UTC) #6
dusan.simicic
https://codereview.chromium.org/2753903004/diff/60001/test/cctest/wasm/test-run-wasm-simd.cc File test/cctest/wasm/test-run-wasm-simd.cc (right): https://codereview.chromium.org/2753903004/diff/60001/test/cctest/wasm/test-run-wasm-simd.cc#newcode39 test/cctest/wasm/test-run-wasm-simd.cc:39: #endif // !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_IA32 On 2017/03/27 ...
3 years, 8 months ago (2017-03-28 08:59:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753903004/80001
3 years, 8 months ago (2017-03-29 12:21:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37961)
3 years, 8 months ago (2017-03-29 12:24:38 UTC) #16
dusan.simicic
+ mtrofin for src/compiler/instruction-selector.cc
3 years, 8 months ago (2017-03-29 12:29:45 UTC) #18
dusan.simicic
PS6: rebased and changed opcode names according to https://codereview.chromium.org/2776753004/ PTAL again
3 years, 8 months ago (2017-03-31 12:54:25 UTC) #20
Mircea Trofin
On 2017/03/31 12:54:25, dusan.simicic wrote: > PS6: rebased and changed opcode names according to > ...
3 years, 8 months ago (2017-03-31 15:14:33 UTC) #21
bbudge
Still LGTM.
3 years, 8 months ago (2017-03-31 16:20:32 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753903004/120001
3 years, 8 months ago (2017-04-03 08:20:42 UTC) #33
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 08:22:26 UTC) #36
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/12faf0f87f0d180abdfe294f6646bbf2044...

Powered by Google App Engine
This is Rietveld 408576698