Fix theme change paint issue on linux.

Fix theme change paint issue on linux.

Merging to M58

We had added a recursion guard in the Widget::OnNativeThemeUpdated() function in this patch
https://codereview.chromium.org/2703933002. This was to work around a crash we were seeing
on Windows where views would be added/removed while the rootview was propagating the theme
changed notification to child views effectively making the iterators invalid.

The recursion killer check in Widget::FrameTypeChanged() causes a painting bug on Linux.

The callstack thanks to thomasanderson is here.


The BrowserView::UserChangedTheme() function also has a recursion killer which is not set to
true here, which indicates that this stack is legitimate.

Fixes as below:
1. BrowserFrame now overrides the Widget::OnNativeThemeUpdated() function. After calling the base class
   we call the newly added function NativeThemeUpdated() in the BrowserView which ensures that we don't
   nuke the views while the iteration is going on in View::PropagateNativeThemeChanged()

2. In the HWNDMessageHandler::SetFullscreen method we update the fullscreen window map after we call PerformDwmTransition(). This internally at times causes a window pos changed to treat the now non fullscreen window as fullscreen leading to a DCHECK. Fixed by moving this code above.

I verified that this does not regress the previous theme fix http://crbug.com/681525 on Windows.

BUG=700135
TBR=sky
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2743793003
Cr-Commit-Position: refs/heads/master@{#456580}
(cherry picked from commit 3d0d1cdfad3fd70d8d579dd03004b4e09d01f2f1)

Review-Url: https://codereview.chromium.org/2753813003
Cr-Commit-Position: refs/branch-heads/3029@{#214}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/9b58fa9d8b8e60498a56101a16987d85d9ffecab

[ananta, 2017-03-15 20:05:45]

Description was changed from

==========
Fix theme change paint issue on linux.

Merging to M58

We had added a recursion guard in the Widget::OnNativeThemeUpdated() function in
this patch
https://codereview.chromium.org/2703933002. This was to work around a crash we
were seeing
on Windows where views would be added/removed while the rootview was propagating
the theme
changed notification to child views effectively making the iterators invalid.

The recursion killer check in Widget::FrameTypeChanged() causes a painting bug
on Linux.

The callstack thanks to thomasanderson is here.


The BrowserView::UserChangedTheme() function also has a recursion killer which
is not set to
true here, which indicates that this stack is legitimate.

Fixes as below:
1. BrowserFrame now overrides the Widget::OnNativeThemeUpdated() function. After
calling the base class
   we call the newly added function NativeThemeUpdated() in the BrowserView
which ensures that we don't
   nuke the views while the iteration is going on in
View::PropagateNativeThemeChanged()

2. In the HWNDMessageHandler::SetFullscreen method we update the fullscreen
window map after we call PerformDwmTransition(). This internally at times causes
a window pos changed to treat the now non fullscreen window as fullscreen
leading to a DCHECK. Fixed by moving this code above.

I verified that this does not regress the previous theme fix
http://crbug.com/681525 on Windows.

BUG=700135

Review-Url: https://codereview.chromium.org/2743793003
Cr-Commit-Position: refs/heads/master@{#456580}
(cherry picked from commit 3d0d1cdfad3fd70d8d579dd03004b4e09d01f2f1)
==========

to

==========
Fix theme change paint issue on linux.

Merging to M58

We had added a recursion guard in the Widget::OnNativeThemeUpdated() function in
this patch
https://codereview.chromium.org/2703933002. This was to work around a crash we
were seeing
on Windows where views would be added/removed while the rootview was propagating
the theme
changed notification to child views effectively making the iterators invalid.

The recursion killer check in Widget::FrameTypeChanged() causes a painting bug
on Linux.

The callstack thanks to thomasanderson is here.


The BrowserView::UserChangedTheme() function also has a recursion killer which
is not set to
true here, which indicates that this stack is legitimate.

Fixes as below:
1. BrowserFrame now overrides the Widget::OnNativeThemeUpdated() function. After
calling the base class
   we call the newly added function NativeThemeUpdated() in the BrowserView
which ensures that we don't
   nuke the views while the iteration is going on in
View::PropagateNativeThemeChanged()

2. In the HWNDMessageHandler::SetFullscreen method we update the fullscreen
window map after we call PerformDwmTransition(). This internally at times causes
a window pos changed to treat the now non fullscreen window as fullscreen
leading to a DCHECK. Fixed by moving this code above.

I verified that this does not regress the previous theme fix
http://crbug.com/681525 on Windows.

BUG=700135
TBR=sky

Review-Url: https://codereview.chromium.org/2743793003
Cr-Commit-Position: refs/heads/master@{#456580}
(cherry picked from commit 3d0d1cdfad3fd70d8d579dd03004b4e09d01f2f1)
==========

[ananta, 2017-03-15 20:06:02]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2017-03-15 20:08:01]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:08:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 20:08:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:08:50]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[ananta, 2017-03-15 20:11:05]

Description was changed from

==========
Fix theme change paint issue on linux.

Merging to M58

We had added a recursion guard in the Widget::OnNativeThemeUpdated() function in
this patch
https://codereview.chromium.org/2703933002. This was to work around a crash we
were seeing
on Windows where views would be added/removed while the rootview was propagating
the theme
changed notification to child views effectively making the iterators invalid.

The recursion killer check in Widget::FrameTypeChanged() causes a painting bug
on Linux.

The callstack thanks to thomasanderson is here.


The BrowserView::UserChangedTheme() function also has a recursion killer which
is not set to
true here, which indicates that this stack is legitimate.

Fixes as below:
1. BrowserFrame now overrides the Widget::OnNativeThemeUpdated() function. After
calling the base class
   we call the newly added function NativeThemeUpdated() in the BrowserView
which ensures that we don't
   nuke the views while the iteration is going on in
View::PropagateNativeThemeChanged()

2. In the HWNDMessageHandler::SetFullscreen method we update the fullscreen
window map after we call PerformDwmTransition(). This internally at times causes
a window pos changed to treat the now non fullscreen window as fullscreen
leading to a DCHECK. Fixed by moving this code above.

I verified that this does not regress the previous theme fix
http://crbug.com/681525 on Windows.

BUG=700135
TBR=sky

Review-Url: https://codereview.chromium.org/2743793003
Cr-Commit-Position: refs/heads/master@{#456580}
(cherry picked from commit 3d0d1cdfad3fd70d8d579dd03004b4e09d01f2f1)
==========

to

==========
Fix theme change paint issue on linux.

Merging to M58

We had added a recursion guard in the Widget::OnNativeThemeUpdated() function in
this patch
https://codereview.chromium.org/2703933002. This was to work around a crash we
were seeing
on Windows where views would be added/removed while the rootview was propagating
the theme
changed notification to child views effectively making the iterators invalid.

The recursion killer check in Widget::FrameTypeChanged() causes a painting bug
on Linux.

The callstack thanks to thomasanderson is here.


The BrowserView::UserChangedTheme() function also has a recursion killer which
is not set to
true here, which indicates that this stack is legitimate.

Fixes as below:
1. BrowserFrame now overrides the Widget::OnNativeThemeUpdated() function. After
calling the base class
   we call the newly added function NativeThemeUpdated() in the BrowserView
which ensures that we don't
   nuke the views while the iteration is going on in
View::PropagateNativeThemeChanged()

2. In the HWNDMessageHandler::SetFullscreen method we update the fullscreen
window map after we call PerformDwmTransition(). This internally at times causes
a window pos changed to treat the now non fullscreen window as fullscreen
leading to a DCHECK. Fixed by moving this code above.

I verified that this does not regress the previous theme fix
http://crbug.com/681525 on Windows.

BUG=700135
TBR=sky
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2743793003
Cr-Commit-Position: refs/heads/master@{#456580}
(cherry picked from commit 3d0d1cdfad3fd70d8d579dd03004b4e09d01f2f1)
==========

[ananta, 2017-03-15 20:11:10]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:11:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 20:24:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489608670115360, "parent_rev":
"49847a3deae80d50b37c471d69ba5db3b3332051", "commit_rev":
"9b58fa9d8b8e60498a56101a16987d85d9ffecab"}

[commit-bot: I haz the power, 2017-03-15 20:25:13]

Description was changed from

==========
Fix theme change paint issue on linux.

Merging to M58

We had added a recursion guard in the Widget::OnNativeThemeUpdated() function in
this patch
https://codereview.chromium.org/2703933002. This was to work around a crash we
were seeing
on Windows where views would be added/removed while the rootview was propagating
the theme
changed notification to child views effectively making the iterators invalid.

The recursion killer check in Widget::FrameTypeChanged() causes a painting bug
on Linux.

The callstack thanks to thomasanderson is here.


The BrowserView::UserChangedTheme() function also has a recursion killer which
is not set to
true here, which indicates that this stack is legitimate.

Fixes as below:
1. BrowserFrame now overrides the Widget::OnNativeThemeUpdated() function. After
calling the base class
   we call the newly added function NativeThemeUpdated() in the BrowserView
which ensures that we don't
   nuke the views while the iteration is going on in
View::PropagateNativeThemeChanged()

2. In the HWNDMessageHandler::SetFullscreen method we update the fullscreen
window map after we call PerformDwmTransition(). This internally at times causes
a window pos changed to treat the now non fullscreen window as fullscreen
leading to a DCHECK. Fixed by moving this code above.

I verified that this does not regress the previous theme fix
http://crbug.com/681525 on Windows.

BUG=700135
TBR=sky
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2743793003
Cr-Commit-Position: refs/heads/master@{#456580}
(cherry picked from commit 3d0d1cdfad3fd70d8d579dd03004b4e09d01f2f1)
==========

to

==========
Fix theme change paint issue on linux.

Merging to M58

We had added a recursion guard in the Widget::OnNativeThemeUpdated() function in
this patch
https://codereview.chromium.org/2703933002. This was to work around a crash we
were seeing
on Windows where views would be added/removed while the rootview was propagating
the theme
changed notification to child views effectively making the iterators invalid.

The recursion killer check in Widget::FrameTypeChanged() causes a painting bug
on Linux.

The callstack thanks to thomasanderson is here.


The BrowserView::UserChangedTheme() function also has a recursion killer which
is not set to
true here, which indicates that this stack is legitimate.

Fixes as below:
1. BrowserFrame now overrides the Widget::OnNativeThemeUpdated() function. After
calling the base class
   we call the newly added function NativeThemeUpdated() in the BrowserView
which ensures that we don't
   nuke the views while the iteration is going on in
View::PropagateNativeThemeChanged()

2. In the HWNDMessageHandler::SetFullscreen method we update the fullscreen
window map after we call PerformDwmTransition(). This internally at times causes
a window pos changed to treat the now non fullscreen window as fullscreen
leading to a DCHECK. Fixed by moving this code above.

I verified that this does not regress the previous theme fix
http://crbug.com/681525 on Windows.

BUG=700135
TBR=sky
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2743793003
Cr-Commit-Position: refs/heads/master@{#456580}
(cherry picked from commit 3d0d1cdfad3fd70d8d579dd03004b4e09d01f2f1)

Review-Url: https://codereview.chromium.org/2753813003
Cr-Commit-Position: refs/branch-heads/3029@{#214}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b58fa9d8b8e60498a56101a1698...
==========

[commit-bot: I haz the power, 2017-03-15 20:25:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b58fa9d8b8e60498a56101a1698...