Fix theme change paint issue on linux.

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 1638 matching lines @@
                                         window_title);
     case TabAlertState::TAB_CAPTURING:
       return l10n_util::GetStringFUTF16(IDS_TAB_AX_LABEL_TAB_CAPTURING_FORMAT,
                                         window_title);
     case TabAlertState::NONE:
       return window_title;
   }
   return base::string16();
 }
 
+void BrowserView::NativeThemeUpdated(const ui::NativeTheme* theme) {
+  // We don't handle theme updates in OnThemeChanged() as that function is
+  // called while views are being iterated over. Please see
+  // View::PropagateNativeThemeChanged() for details. The theme update
+  // handling in UserChangedTheme() can cause views to be nuked or created
+  // which is a bad thing during iteration.
+
+  // Do not handle native theme changes before the browser view is initialized.
+  if (!initialized_)
+    return;
+  // Don't infinitely recurse.
+  if (!handling_theme_changed_)
+    UserChangedTheme();
+  chrome::MaybeShowInvertBubbleView(this);
+}
+
 views::View* BrowserView::GetInitiallyFocusedView() {
   return nullptr;
 }
 
 bool BrowserView::ShouldShowWindowTitle() const {
 #if defined(OS_CHROMEOS)
   // For Chrome OS only, trusted windows (apps and settings) do not show a
   // title, crbug.com/119411. Child windows (i.e. popups) do show a title.
   if (browser_->is_trusted_source())
     return false;
@@ skipping 314 matching lines @@
     base::AutoReset<bool> reset(&handling_theme_changed_, true);
 #if defined(USE_AURA)
     ui::NativeThemeDarkAura::instance()->NotifyObservers();
 #endif
     ui::NativeTheme::GetInstanceForNativeUi()->NotifyObservers();
   }
 
   views::View::OnThemeChanged();
 }
 
-void BrowserView::OnNativeThemeChanged(const ui::NativeTheme* theme) {
-  // Do not handle native theme changes before the browser view is initialized.
-  if (!initialized_)
-    return;
-  ClientView::OnNativeThemeChanged(theme);
-  // Don't infinitely recurse.
-  if (!handling_theme_changed_)
-    UserChangedTheme();
-  chrome::MaybeShowInvertBubbleView(this);
-}
-
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserView, ui::AcceleratorTarget overrides:
 
 bool BrowserView::AcceleratorPressed(const ui::Accelerator& accelerator) {
   std::map<ui::Accelerator, int>::const_iterator iter =
       accelerator_table_.find(accelerator);
   DCHECK(iter != accelerator_table_.end());
   int command_id = iter->second;
 
   if (accelerator.IsRepeat() && !IsCommandRepeatable(command_id))
@@ skipping 653 matching lines @@
 }
 
 extensions::ActiveTabPermissionGranter*
 BrowserView::GetActiveTabPermissionGranter() {
   content::WebContents* web_contents = GetActiveWebContents();
   if (!web_contents)
     return nullptr;
   return extensions::TabHelper::FromWebContents(web_contents)
       ->active_tab_permission_granter();
 }