Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1830)

Issue 2753513008: Merge 58: Avoid calling VEA::Destroy() in VideoTrackRecorder (Closed)

Created:
3 years, 9 months ago by emircan
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge 58: Avoid calling VEA::Destroy() in VideoTrackRecorder The default deleter for VEA calls Destroy() by default[0]. Running it multiple times can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?rcl=575512843787644524196d04076a59ec9415cb89&l=186 BUG=701450 TEST=Fixes the crash described in the bug. Review-Url: https://codereview.chromium.org/2753593002 Cr-Commit-Position: refs/heads/master@{#456851} (cherry picked from commit 98557de3bc84264df66670ca5baa7e0765f2186f) NOTRY=true NOPRESUBMIT=true TBR=mcasas@chromium.org Review-Url: https://codereview.chromium.org/2753513008 Cr-Commit-Position: refs/branch-heads/3029@{#219} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/813c97a414763063352914dd35fe9ea426852acf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/renderer/media_recorder/video_track_recorder.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753513008/1
3 years, 9 months ago (2017-03-15 22:05:57 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 22:09:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/813c97a414763063352914dd35fe...

Powered by Google App Engine
This is Rietveld 408576698