Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2753593002:
Avoid calling VEA::Destroy() in VideoTrackRecorder (Closed)
|
Created:
3 years, 9 months ago by emircan Modified:
3 years, 9 months ago Reviewers:
mcasas CC:
chromium-reviews, mlamouri+watch-content_chromium.org, emircan+watch+mediarecorder_chromium.org, posciak+watch_chromium.org, jam, darin-cc_chromium.org, mcasas+mediarecorder_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid calling VEA::Destroy() in VideoTrackRecorder
The default deleter for VEA calls Destroy() by default[0]. Running it multiple times can
cause a crash, see bug.
[0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?rcl=575512843787644524196d04076a59ec9415cb89&l=186
BUG=701450
TEST=Fixes the crash described in the bug.
Review-Url: https://codereview.chromium.org/2753593002
Cr-Commit-Position: refs/heads/master@{#456851}
Committed: https://chromium.googlesource.com/chromium/src/+/98557de3bc84264df66670ca5baa7e0765f2186f
Patch Set 1 #
Messages
Total messages: 18 (14 generated)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== change default deleter. BUG= ========== to ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy by default[0]. Running it multiple times in can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
Description was changed from ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy by default[0]. Running it multiple times in can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 ========== to ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy by default[0]. Running it multiple times in can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Tested changing screen resolution on recording using Mac H264 VEA. ==========
Description was changed from ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy by default[0]. Running it multiple times in can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Tested changing screen resolution on recording using Mac H264 VEA. ========== to ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy by default[0]. Running it multiple times in can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Fixes the crash described in the bug. ==========
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy by default[0]. Running it multiple times in can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Fixes the crash described in the bug. ========== to ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy by default[0]. Running it multiple times can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Fixes the crash described in the bug. ==========
Description was changed from ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy by default[0]. Running it multiple times can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Fixes the crash described in the bug. ========== to ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy() by default[0]. Running it multiple times can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Fixes the crash described in the bug. ==========
lgtm CL title nit: s/MediaRecorder/VideoTrackRecorder/ ?
Description was changed from ========== Avoid calling VEA::Destroy() in MediaRecorder The default deleter for VEA calls Destroy() by default[0]. Running it multiple times can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Fixes the crash described in the bug. ========== to ========== Avoid calling VEA::Destroy() in VideoTrackRecorder The default deleter for VEA calls Destroy() by default[0]. Running it multiple times can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Fixes the crash described in the bug. ==========
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489527856329500, "parent_rev":
"7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e", "commit_rev":
"98557de3bc84264df66670ca5baa7e0765f2186f"}
Message was sent while issue was closed.
Description was changed from ========== Avoid calling VEA::Destroy() in VideoTrackRecorder The default deleter for VEA calls Destroy() by default[0]. Running it multiple times can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Fixes the crash described in the bug. ========== to ========== Avoid calling VEA::Destroy() in VideoTrackRecorder The default deleter for VEA calls Destroy() by default[0]. Running it multiple times can cause a crash, see bug. [0] https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?r... BUG=701450 TEST=Fixes the crash described in the bug. Review-Url: https://codereview.chromium.org/2753593002 Cr-Commit-Position: refs/heads/master@{#456851} Committed: https://chromium.googlesource.com/chromium/src/+/98557de3bc84264df66670ca5baa... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/98557de3bc84264df66670ca5baa... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
