Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3150)

Unified Diff: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Issue 2753513006: Remove ...LOADED_DEPRECATED and its friends (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_crash_recovery_browsertest.cc
diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
index 227951c07cb540e7436d5c994e06e377257f9de2..71e2d98220a67b154e81d5c54fdcdb76c0f22106 100644
--- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
+++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
@@ -29,6 +29,7 @@
#include "extensions/browser/extension_system.h"
#include "extensions/browser/process_manager.h"
#include "extensions/browser/process_map.h"
+#include "extensions/browser/test_extension_registry_observer.h"
#include "extensions/common/constants.h"
#include "ui/message_center/message_center.h"
#include "ui/message_center/notification_list.h"
@@ -143,8 +144,11 @@ class MAYBE_ExtensionCrashRecoveryTest : public ExtensionCrashRecoveryTestBase {
for (size_t i = 0; i < index; ++i)
++it;
std::string id = (*it)->id();
+ extensions::TestExtensionRegistryObserver observer(GetExtensionRegistry());
message_center->ClickOnNotification(id);
- WaitForExtensionLoad();
+ observer.WaitForExtensionLoaded();
+ // Wait until extension's frame created.
+ base::RunLoop().RunUntilIdle();
Devlin 2017/03/30 22:21:57 I think this is a little less deterministic than t
limasdf 2017/04/03 13:52:50 At the moment when WaitForExtensionViewsToloaded()
limasdf 2017/04/06 15:58:57 Done.
}
void CancelNotification(size_t index) override {

Powered by Google App Engine
This is Rietveld 408576698