Remove ...LOADED_DEPRECATED and its friends

Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of NOTIFICATION_EXTENSION_LOADED_DEPRECATED
from ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad()
since it has a possibility to catch unexpected extension's loaded 
notification. Instead of that, use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2753513006
Cr-Commit-Position: refs/heads/master@{#464703}
Committed: https://chromium.googlesource.com/chromium/src/+/184283c3b2e690cf6839278e7dfb034fe98413b3

[limasdf, 2017-03-28 03:46:04]

Patchset #6 (id:100001) has been deleted

[limasdf, 2017-03-28 03:47:42]

Patchset #4 (id:60001) has been deleted

[limasdf, 2017-03-28 03:47:51]

Patchset #2 (id:20001) has been deleted

[limasdf, 2017-03-28 03:48:04]

Patchset #3 (id:80001) has been deleted

[limasdf, 2017-03-28 03:48:22]

Patchset #1 (id:1) has been deleted

[limasdf, 2017-03-29 13:43:10]

Patchset #3 (id:140001) has been deleted

[limasdf, 2017-03-29 13:46:27]

Patchset #4 (id:180001) has been deleted

[limasdf, 2017-03-29 13:47:19]

Patchset #4 (id:200001) has been deleted

[limasdf, 2017-03-29 13:47:24]

Patchset #3 (id:160001) has been deleted

[limasdf, 2017-03-29 13:47:34]

Patchset #1 (id:40001) has been deleted

[limasdf, 2017-03-29 13:47:39]

Patchset #1 (id:120001) has been deleted

[limasdf, 2017-03-29 13:50:00]

Description was changed from

==========
Remove loaded

BUG=
==========

to

==========
Remove deprecated notification and its friends from
extension_test_notification_observer

BUG=
==========

[limasdf, 2017-03-29 14:42:39]

The CQ bit was checked by limasdf@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 14:42:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[limasdf, 2017-03-29 14:43:38]

Description was changed from

==========
Remove deprecated notification and its friends from
extension_test_notification_observer

BUG=
==========

to

==========
Remove deprecated notification and its friends

BUG=411568
TEST=browser_tests
==========

[limasdf, 2017-03-29 14:43:50]

Description was changed from

==========
Remove deprecated notification and its friends

BUG=411568
TEST=browser_tests
==========

to

==========
Remove deprecated extension notification and its friends

BUG=411568
TEST=browser_tests
==========

[limasdf, 2017-03-29 15:03:29]

Description was changed from

==========
Remove deprecated extension notification and its friends

BUG=411568
TEST=browser_tests
==========

to

==========
Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of
NOTIFICATION_EXTENSION_LOADED_DEPRECATED From ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad() since it
has possibility to catch unexpected extension's loaded notification. instead of
that, Use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests
==========

[limasdf, 2017-03-29 15:03:57]

Description was changed from

==========
Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of
NOTIFICATION_EXTENSION_LOADED_DEPRECATED From ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad() since it
has possibility to catch unexpected extension's loaded notification. instead of
that, Use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests
==========

to

==========
Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of
NOTIFICATION_EXTENSION_LOADED_DEPRECATED From
 ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad()
since it has possibility to catch unexpected extension's loaded 
notification. instead of that, Use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests
==========

[limasdf, 2017-03-29 15:04:22]

Description was changed from

==========
Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of
NOTIFICATION_EXTENSION_LOADED_DEPRECATED From
 ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad()
since it has possibility to catch unexpected extension's loaded 
notification. instead of that, Use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests
==========

to

==========
Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of
NOTIFICATION_EXTENSION_LOADED_DEPRECATED
from ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad()
since it has possibility to catch unexpected extension's loaded 
notification. Instead of that, use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests
==========

[limasdf, 2017-03-29 15:05:16]

Description was changed from

==========
Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of
NOTIFICATION_EXTENSION_LOADED_DEPRECATED
from ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad()
since it has possibility to catch unexpected extension's loaded 
notification. Instead of that, use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests
==========

to

==========
Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of
NOTIFICATION_EXTENSION_LOADED_DEPRECATED
from ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad()
since it has a possibility to catch unexpected extension's loaded 
notification. Instead of that, use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests
==========

[commit-bot: I haz the power, 2017-03-29 15:24:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:24:15]

Dry run: This issue passed the CQ dry run.

[limasdf, 2017-03-29 15:24:54]

limasdf@gmail.com changed reviewers:
+ rdevlin.cronin@chromium.org

[limasdf, 2017-03-29 15:24:55]

Hi Devlin,

Please take a look when you have time.

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
File chrome/browser/extensions/chrome_extension_test_notification_observer.cc
(right):

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/chrome_extension_test_notification_observer.cc:5:
#include
<chrome/browser/extensions/chrome_extension_test_notification_observer.h>
is this intended?   I think < should be "

[Devlin, 2017-03-30 22:21:57]

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
File chrome/browser/extensions/chrome_extension_test_notification_observer.cc
(right):

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/chrome_extension_test_notification_observer.cc:5:
#include
<chrome/browser/extensions/chrome_extension_test_notification_observer.h>
On 2017/03/29 15:24:55, limasdf wrote:
> is this intended?   I think < should be "

Yeah, this should be "".

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
File chrome/browser/extensions/extension_crash_recovery_browsertest.cc (right):

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/extension_crash_recovery_browsertest.cc:151:
base::RunLoop().RunUntilIdle();
I think this is a little less deterministic than the previous method of
listening to WebContents loading and checking them against the process manager;
any reason to migrate away from that tactic (using
WaitForExtensionViewsToLoad())?

[limasdf, 2017-04-03 13:52:50]

Thanks for the comment. I'll ping you again when ready.  (No updates yet. but I
just want to let you know that I'm working on it.)

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
File chrome/browser/extensions/extension_crash_recovery_browsertest.cc (right):

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/extension_crash_recovery_browsertest.cc:151:
base::RunLoop().RunUntilIdle();
On 2017/03/30 22:21:57, Devlin wrote:
> I think this is a little less deterministic than the previous method of
> listening to WebContents loading and checking them against the process
manager;
> any reason to migrate away from that tactic (using
> WaitForExtensionViewsToLoad())?

At the moment when WaitForExtensionViewsToloaded() called,
ProcessManger::all_extension_frames_ doesn't holds the waiting extensions's
frames. because of that, CheckExtensionConsistency(line#104) failed.
 I think I can solve this problem with ProcessManagerObserver.

[limasdf, 2017-04-06 13:20:47]

Patchset #3 (id:260001) has been deleted

[limasdf, 2017-04-06 13:20:55]

Patchset #2 (id:240001) has been deleted

[limasdf, 2017-04-06 15:11:54]

Patchset #3 (id:300001) has been deleted

[limasdf, 2017-04-06 15:12:13]

Patchset #2 (id:280001) has been deleted

[limasdf, 2017-04-06 15:45:00]

Patchset #2 (id:320001) has been deleted

[limasdf, 2017-04-06 15:58:57]

PTAL when you have time.

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
File chrome/browser/extensions/extension_crash_recovery_browsertest.cc (right):

https://codereview.chromium.org/2753513006/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/extension_crash_recovery_browsertest.cc:151:
base::RunLoop().RunUntilIdle();
On 2017/04/03 13:52:50, limasdf wrote:
> On 2017/03/30 22:21:57, Devlin wrote:
> > I think this is a little less deterministic than the previous method of
> > listening to WebContents loading and checking them against the process
> manager;
> > any reason to migrate away from that tactic (using
> > WaitForExtensionViewsToLoad())?
> 
> At the moment when WaitForExtensionViewsToloaded() called,
> ProcessManger::all_extension_frames_ doesn't holds the waiting extensions's
> frames. because of that, CheckExtensionConsistency(line#104) failed.
>  I think I can solve this problem with ProcessManagerObserver.

Done.

[Devlin, 2017-04-06 21:18:13]

Nice!  As long as the bots are happy, lgtm.

Thanks for the cleanup! :)

[limasdf, 2017-04-07 01:12:02]

limasdf@gmail.com changed reviewers:
+ alemate@chromium.org, emaxx@chromium.org

[limasdf, 2017-04-07 02:04:53]

Hi Alexander and emaxx. Could you please take a look this cleanup?

Alexander -> chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc
emaxx -> chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc

[emaxx, 2017-04-07 10:05:26]

LGTM with one note for
chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc

https://codereview.chromium.org/2753513006/diff/350001/chrome/browser/chromeo...
File chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/2753513006/diff/350001/chrome/browser/chromeo...
chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc:30: #include
"chrome/browser/extensions/chrome_test_extension_loader.cc"
.h should be included instead of .cc

[limasdf, 2017-04-07 12:04:40]

https://codereview.chromium.org/2753513006/diff/350001/chrome/browser/chromeo...
File chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/2753513006/diff/350001/chrome/browser/chromeo...
chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc:30: #include
"chrome/browser/extensions/chrome_test_extension_loader.cc"
On 2017/04/07 10:05:25, emaxx wrote:
> .h should be included instead of .cc

Oops. fixed. Thanks!

[Alexander Alekseev, 2017-04-07 22:29:20]

I don't think I am owner of any of these.
It also looks like there are enough "looks good".
Removing myself from reviewers.

[Alexander Alekseev, 2017-04-07 22:29:34]

alemate@chromium.org changed reviewers:
- alemate@chromium.org

[limasdf, 2017-04-08 01:02:32]

The CQ bit was checked by limasdf@gmail.com

[limasdf, 2017-04-08 01:02:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, emaxx@chromium.org
Link to the patchset: https://codereview.chromium.org/2753513006/#ps370001
(title: "include .h")

[commit-bot: I haz the power, 2017-04-08 01:03:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 01:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 01:14:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[limasdf, 2017-04-08 01:20:07]

limasdf@gmail.com changed reviewers:
+ alemate@chromium.org

[limasdf, 2017-04-08 01:21:58]

Alexander, you're the owner of chrome/browser/chromeos/first_run/

the change is small I believe it doesn't take long time to review. PTAL.

[limasdf, 2017-04-14 02:20:08]

limasdf@gmail.com changed reviewers:
+ oshima@chromium.org

[limasdf, 2017-04-14 02:20:45]

Oshima, Would you mind taking a look
hrome/browser/chromeos/first_run/drive_first_run_browsertest.cc?

[oshima, 2017-04-14 07:39:10]

lgtm

[limasdf, 2017-04-14 07:40:08]

Thank you very much, Oshima!

[limasdf, 2017-04-14 07:40:20]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2017-04-14 07:40:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 08:22:14]

CQ is committing da patch.

Bot data: {"patchset_id": 370001, "attempt_start_ts": 1492155620339010,
"parent_rev": "b9b0560ef757a95e871f72263e8932559a0e23d0", "commit_rev":
"184283c3b2e690cf6839278e7dfb034fe98413b3"}

[commit-bot: I haz the power, 2017-04-14 08:23:29]

Description was changed from

==========
Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of
NOTIFICATION_EXTENSION_LOADED_DEPRECATED
from ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad()
since it has a possibility to catch unexpected extension's loaded 
notification. Instead of that, use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests
==========

to

==========
Remove ...LOADED_DEPRECATED and its friends

Use ExtensionRegistryObserver instead of
NOTIFICATION_EXTENSION_LOADED_DEPRECATED
from ExtensionTestNotificationObserver.
Also, Remove ExtensionTestNotificationObserver::WaitForExtensionLoad()
since it has a possibility to catch unexpected extension's loaded 
notification. Instead of that, use TestExtensionRegistryObserver.

BUG=411568
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2753513006
Cr-Commit-Position: refs/heads/master@{#464703}
Committed:
https://chromium.googlesource.com/chromium/src/+/184283c3b2e690cf6839278e7dfb...
==========

[commit-bot: I haz the power, 2017-04-14 08:23:31]

Committed patchset #4 (id:370001) as
https://chromium.googlesource.com/chromium/src/+/184283c3b2e690cf6839278e7dfb...