Remove ...LOADED_DEPRECATED and its friends

chrome/browser/extensions/extension_crash_recovery_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/run_loop.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
@@ skipping 11 matching lines @@
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/result_codes.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/browser/process_map.h"
+#include "extensions/browser/test_extension_registry_observer.h"
 #include "extensions/common/constants.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/notification_list.h"
 
 using content::NavigationController;
 using content::WebContents;
 using extensions::Extension;
 using extensions::ExtensionRegistry;
 
 // Tests are timing out waiting for extension to crash.
@@ skipping 94 matching lines @@
  protected:
   void AcceptNotification(size_t index) override {
     message_center::MessageCenter* message_center =
         message_center::MessageCenter::Get();
     ASSERT_GT(message_center->NotificationCount(), index);
     message_center::NotificationList::Notifications::reverse_iterator it =
         message_center->GetVisibleNotifications().rbegin();
     for (size_t i = 0; i < index; ++i)
       ++it;
     std::string id = (*it)->id();
+    extensions::TestExtensionRegistryObserver observer(GetExtensionRegistry());
     message_center->ClickOnNotification(id);
-    WaitForExtensionLoad();
+    observer.WaitForExtensionLoaded();
+    // Wait until extension's frame created.
+    base::RunLoop().RunUntilIdle();

[Devlin, 2017/03/30 22:21:57]

I think this is a little less deterministic than the previous method of
listening to WebContents loading and checking them against the process manager;
any reason to migrate away from that tactic (using
WaitForExtensionViewsToLoad())?

[limasdf, 2017/04/03 13:52:50]

At the moment when WaitForExtensionViewsToloaded() called,
ProcessManger::all_extension_frames_ doesn't holds the waiting extensions's
frames. because of that, CheckExtensionConsistency(line#104) failed.
 I think I can solve this problem with ProcessManagerObserver.

[limasdf, 2017/04/06 15:58:57]

Done.

   }
 
   void CancelNotification(size_t index) override {
     message_center::MessageCenter* message_center =
         message_center::MessageCenter::Get();
     ASSERT_GT(message_center->NotificationCount(), index);
     message_center::NotificationList::Notifications::reverse_iterator it =
         message_center->GetVisibleNotifications().rbegin();
     for (size_t i = 0; i < index; ++i)
       ++it;
@@ skipping 399 matching lines @@
                 GetController()));
     chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB);
     observer.Wait();
   }
   // Extension should now be loaded.
   SCOPED_TRACE("after reloading the tab");
   CheckExtensionConsistency(first_extension_id_);
   ASSERT_EQ(count_before + 1, GetEnabledExtensionCount());
   ASSERT_EQ(0U, CountBalloons());
 }