ChromeOS OOBE: display icons specific to screen DPI.

ChromeOS OOBE: display icons specific to screen DPI.

BUG=642085
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2753513002
Cr-Commit-Position: refs/heads/master@{#457170}
Committed: https://chromium.googlesource.com/chromium/src/+/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac

[Alexander Alekseev, 2017-03-14 11:27:31]

Description was changed from

==========
ChromeOS OOBE: display icons specific to screen DPI.

BUG=642085
==========

to

==========
ChromeOS OOBE: display icons specific to screen DPI.

BUG=642085
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2017-03-14 11:28:03]

alemate@chromium.org changed reviewers:
+ jdufault@chromium.org

[Alexander Alekseev, 2017-03-14 11:28:04]

Please review.

[Alexander Alekseev, 2017-03-14 11:28:11]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 11:28:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 12:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 12:49:57]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-03-14 17:48:55]

https://codereview.chromium.org/2753513002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2753513002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.html:98: <iron-icon
icon="oobe-welcome-32:language" class="oobe-icon oobe-icon-1x">
What about making a <hd-iron-icon> (needs a better name) that wraps the logic
here?

  <hd-iron-icon icon="oobe-welcome:language" class="oobe-icon"></hd-iron-icon>

This then picks the correct 1x or 2x asset as needed.

[Alexander Alekseev, 2017-03-15 06:44:23]

https://codereview.chromium.org/2753513002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2753513002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.html:98: <iron-icon
icon="oobe-welcome-32:language" class="oobe-icon oobe-icon-1x">
On 2017/03/14 17:48:55, jdufault wrote:
> What about making a <hd-iron-icon> (needs a better name) that wraps the logic
> here?
> 
>   <hd-iron-icon icon="oobe-welcome:language" class="oobe-icon"></hd-iron-icon>
> 
> This then picks the correct 1x or 2x asset as needed.

Done.

[Alexander Alekseev, 2017-03-15 07:52:06]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 07:52:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 09:03:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 09:03:03]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-03-15 16:51:40]

lgtm

https://codereview.chromium.org/2753513002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html (right):

https://codereview.chromium.org/2753513002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html:29:
icon1x="oobe-welcome-32:language"
I'm okay with leaving as is because being explicit is always nice, but I think
it would be cleaner if we automatically appended the 32/64 because as is there
is some duplication and the oobe-dialog interface is now tied to hd-iron-icon.

[Alexander Alekseev, 2017-03-15 19:14:04]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2017-03-15 19:14:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 19:40:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489605244810350,
"parent_rev": "98c9f805b64f60e6dc4a0b305d09a176b4eb105d", "commit_rev":
"a4c32ce963c3ff25beb2edbd857f8906c22ad6ac"}

[commit-bot: I haz the power, 2017-03-15 19:40:43]

Description was changed from

==========
ChromeOS OOBE: display icons specific to screen DPI.

BUG=642085
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS OOBE: display icons specific to screen DPI.

BUG=642085
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2753513002
Cr-Commit-Position: refs/heads/master@{#457170}
Committed:
https://chromium.googlesource.com/chromium/src/+/a4c32ce963c3ff25beb2edbd857f...
==========

[commit-bot: I haz the power, 2017-03-15 19:40:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a4c32ce963c3ff25beb2edbd857f...