Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2289)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html

Issue 2753513002: ChromeOS OOBE: display icons specific to screen DPI. (Closed)
Patch Set: Added hr-iron-icon Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
diff --git a/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html b/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
index 11b374c09a5d87d92b3ab017d8ba3824e23bdfff..125a476bde026e53d5a92260536cc679203950f3 100644
--- a/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
+++ b/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
@@ -26,17 +26,23 @@
<div class="flex"></div>
<div id="buttons" class="layout horizontal center">
<oobe-welcome-secondary-button id="languageSelectionButton"
- icon="icons:language" on-tap="onLanguageClicked_"
+ icon1x="oobe-welcome-32:language"
jdufault 2017/03/15 16:51:40 I'm okay with leaving as is because being explicit
+ icon2x="oobe-welcome-64:language"
+ on-tap="onLanguageClicked_"
label-for-aria$="[[formatMessage_('languageButtonLabel',
currentLanguage)]]">
<div>[[currentLanguage]]</div>
</oobe-welcome-secondary-button>
<oobe-welcome-secondary-button id="accessibilitySettingsButton"
- icon="icons:accessibility" on-tap="onAccessibilityClicked_">
+ icon1x="oobe-welcome-32:accessibility"
+ icon2x="oobe-welcome-64:accessibility"
+ on-tap="onAccessibilityClicked_">
<div i18n-content="accessibilityLink"></div>
</oobe-welcome-secondary-button>
<oobe-welcome-secondary-button id="timezoneSettingsButton"
- icon="oobe-welcome-64:timezone" on-tap="onTimezoneClicked_"
+ icon1x="oobe-welcome-32:timezone"
+ icon2x="oobe-welcome-64:timezone"
+ on-tap="onTimezoneClicked_"
hidden="[[!timezoneButtonVisible]]">
<div i18n-content="timezoneButtonText"></div>
</oobe-welcome-secondary-button>

Powered by Google App Engine
This is Rietveld 408576698