Issue 2753493002: Merge 3029: Avoid uloc_setKeywordValue if the locale contains "@"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2753493002: Merge 3029: Avoid uloc_setKeywordValue if the locale contains "@" (Closed)

Created:
3 years, 9 months ago by kojii

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Merge 3029: Avoid uloc_setKeywordValue if the locale contains "@" This patch avoids calling ICU uloc_setKeywordValue if the locale string contains "@". This looks like a bug in ICU, I will report to ICU separately. BUG=697859 Review-Url: https://codereview.chromium.org/2725243003 Cr-Commit-Position: refs/heads/master@{#454523} (cherry picked from commit 156a9b90ac5612a39b1be4ee1e80042093df0c5a) Review-Url: https://codereview.chromium.org/2753493002 . Cr-Commit-Position: refs/branch-heads/3029@{#180} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/ed9223e54fedd9aabcd753e9e715bd5d87e1518b

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/platform/LayoutLocale.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/platform/LayoutLocaleTest.cpp	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

kojii

3 years, 9 months ago (2017-03-14 03:49:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ed9223e54fedd9aabcd753e9e715bd5d87e1518b.