Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2725243003: Avoid uloc_setKeywordValue if the locale contains "@" (Closed)

Created:
3 years, 9 months ago by kojii
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid uloc_setKeywordValue if the locale contains "@" This patch avoids calling ICU uloc_setKeywordValue if the locale string contains "@". This looks like a bug in ICU, I will report to ICU separately. BUG=697859 Review-Url: https://codereview.chromium.org/2725243003 Cr-Commit-Position: refs/heads/master@{#454523} Committed: https://chromium.googlesource.com/chromium/src/+/156a9b90ac5612a39b1be4ee1e80042093df0c5a

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/LayoutLocale.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/LayoutLocaleTest.cpp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
kojii
PTAL.
3 years, 9 months ago (2017-03-03 03:48:53 UTC) #8
eae
LGTM
3 years, 9 months ago (2017-03-03 05:51:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725243003/20001
3 years, 9 months ago (2017-03-03 05:52:41 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 05:57:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/156a9b90ac5612a39b1be4ee1e80...

Powered by Google App Engine
This is Rietveld 408576698