Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2753313002: cros: Init SystemTrayDelegate earlier to break bluetooth init dependency (Closed)

Created:
3 years, 9 months ago by James Cook
Modified:
3 years, 9 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Init SystemTrayDelegate earlier to break bluetooth init dependency This is needed to allow TrayBluetoothHelper to move into //ash, which is required to get Bluetooth working in mutash. SystemTrayDelegateChromeOS used to have a two-step initialization process with some code being initialized after the Bluetooth adapter becomes available. I think that init doesn't need to wait on Bluetooth init. BUG=660043 TEST=browser_tests, device starts normally Review-Url: https://codereview.chromium.org/2753313002 Cr-Commit-Position: refs/heads/master@{#457894} Committed: https://chromium.googlesource.com/chromium/src/+/817c808f00fbc1d292d01d8fcfbf423e36c6c28d

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -29 lines) Patch
M ash/common/system/tray/system_tray_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/tray_bluetooth_helper.h View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/ui/ash/tray_bluetooth_helper.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/tray_bluetooth_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
James Cook
xiyuan, please take a look. This is Phase 2 of this refactor plan: https://docs.google.com/document/d/1524xuf9cDBDbY_fl6f-IAHanl8lHA244ds24CgKeGK0/edit
3 years, 9 months ago (2017-03-17 18:25:30 UTC) #4
xiyuan
lgtm
3 years, 9 months ago (2017-03-17 20:19:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753313002/20001
3 years, 9 months ago (2017-03-17 22:25:09 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 22:37:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/817c808f00fbc1d292d01d8fcfbf...

Powered by Google App Engine
This is Rietveld 408576698