cros: Convert SystemTrayDelegate::ManageBluetoothDevices to mojo for mash

cros: Convert SystemTrayDelegate::ManageBluetoothDevices to mojo for mash

This is needed to eliminate the in-process ash-to-chrome calls via
SystemTrayDelegate and to support Bluetooth directly from ash.

* Convert ManageBluetoothDevices to SystemTrayClient::ShowBluetoothSettings
* Introduce ShowBluetoothPairingDialog() which will be needed shortly

The next step is to move TrayBluetoothHelper out of //chrome into //ash.

BUG=660043
TEST=Existing UI tests. The settings "gear" in the system tray bluetooth
section still opens settings.

Review-Url: https://codereview.chromium.org/2754143006
Cr-Commit-Position: refs/heads/master@{#458106}
Committed: https://chromium.googlesource.com/chromium/src/+/67435be443d0a9f45d85a0c5a013c7723114315e

[James Cook, 2017-03-17 22:23:29]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org, tsepez@chromium.org

[James Cook, 2017-03-17 22:23:30]

msw, please take a look.

tsepez, please take a look at ash/public/interfaces/system_tray.mojom

https://codereview.chromium.org/2754143006/diff/20001/ash/public/interfaces/s...
File ash/public/interfaces/system_tray.mojom (right):

https://codereview.chromium.org/2754143006/diff/20001/ash/public/interfaces/s...
ash/public/interfaces/system_tray.mojom:45: ShowBluetoothPairingDialog(string
address,
This method isn't called yet, but is used to generate the function signature in
SystemTrayClient() that I'll need in the next CL.

https://codereview.chromium.org/2754143006/diff/20001/ash/public/interfaces/s...
ash/public/interfaces/system_tray.mojom:47: bool paired,
I do not know why you would show a pairing dialog if |paired| was true, but
that's how it works today.

https://codereview.chromium.org/2754143006/diff/20001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_client.cc (right):

https://codereview.chromium.org/2754143006/diff/20001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_client.cc:221: void
SystemTrayClient::ShowBluetoothSettings() {
Moved from SystemTrayDelegateChromeOS.

https://codereview.chromium.org/2754143006/diff/20001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_client.cc:226: void
SystemTrayClient::ShowBluetoothPairingDialog(
Moved from TrayBluetoothHelper.

[James Cook, 2017-03-17 22:23:37]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 22:24:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-03-17 22:35:22]

lgtm

[commit-bot: I haz the power, 2017-03-17 23:38:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 23:38:11]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-03-17 23:42:26]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 23:43:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 00:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 00:35:53]

Dry run: This issue passed the CQ dry run.

[msw, 2017-03-18 00:44:44]

lgtm

https://codereview.chromium.org/2754143006/diff/20001/ash/public/interfaces/s...
File ash/public/interfaces/system_tray.mojom (right):

https://codereview.chromium.org/2754143006/diff/20001/ash/public/interfaces/s...
ash/public/interfaces/system_tray.mojom:45: ShowBluetoothPairingDialog(string
address,
On 2017/03/17 22:23:30, James Cook wrote:
> This method isn't called yet, but is used to generate the function signature
in
> SystemTrayClient() that I'll need in the next CL.

Acknowledged.

https://codereview.chromium.org/2754143006/diff/20001/ash/public/interfaces/s...
ash/public/interfaces/system_tray.mojom:47: bool paired,
On 2017/03/17 22:23:30, James Cook wrote:
> I do not know why you would show a pairing dialog if |paired| was true, but
> that's how it works today.

Acknowledged.

https://codereview.chromium.org/2754143006/diff/20001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_client.cc (right):

https://codereview.chromium.org/2754143006/diff/20001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_client.cc:221: void
SystemTrayClient::ShowBluetoothSettings() {
On 2017/03/17 22:23:30, James Cook wrote:
> Moved from SystemTrayDelegateChromeOS.

Acknowledged.

https://codereview.chromium.org/2754143006/diff/20001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_client.cc:226: void
SystemTrayClient::ShowBluetoothPairingDialog(
On 2017/03/17 22:23:30, James Cook wrote:
> Moved from TrayBluetoothHelper.

Acknowledged.

[James Cook, 2017-03-19 18:35:39]

jamescook@chromium.org changed reviewers:
+ xiyuan@chromium.org

[James Cook, 2017-03-19 18:35:40]

xiyuan, can I get OWNERS for c/b/chromeos ?

[James Cook, 2017-03-19 19:13:14]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-19 19:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-19 19:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 19:52:57]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-03-20 15:39:42]

c/b/chromeos lgtm

[James Cook, 2017-03-20 16:54:54]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-03-20 16:54:55]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2754143006/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-20 16:55:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 17:16:38]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490028894637840,
"parent_rev": "be5b17ba520de8c5ebf31d4c4dfac8be44a50366", "commit_rev":
"67435be443d0a9f45d85a0c5a013c7723114315e"}

[commit-bot: I haz the power, 2017-03-20 17:17:18]

Description was changed from

==========
cros: Convert SystemTrayDelegate::ManageBluetoothDevices to mojo for mash

This is needed to eliminate the in-process ash-to-chrome calls via
SystemTrayDelegate and to support Bluetooth directly from ash.

* Convert ManageBluetoothDevices to SystemTrayClient::ShowBluetoothSettings
* Introduce ShowBluetoothPairingDialog() which will be needed shortly

The next step is to move TrayBluetoothHelper out of //chrome into //ash.

BUG=660043
TEST=Existing UI tests. The settings "gear" in the system tray bluetooth
section still opens settings.
==========

to

==========
cros: Convert SystemTrayDelegate::ManageBluetoothDevices to mojo for mash

This is needed to eliminate the in-process ash-to-chrome calls via
SystemTrayDelegate and to support Bluetooth directly from ash.

* Convert ManageBluetoothDevices to SystemTrayClient::ShowBluetoothSettings
* Introduce ShowBluetoothPairingDialog() which will be needed shortly

The next step is to move TrayBluetoothHelper out of //chrome into //ash.

BUG=660043
TEST=Existing UI tests. The settings "gear" in the system tray bluetooth
section still opens settings.

Review-Url: https://codereview.chromium.org/2754143006
Cr-Commit-Position: refs/heads/master@{#458106}
Committed:
https://chromium.googlesource.com/chromium/src/+/67435be443d0a9f45d85a0c5a013...
==========

[commit-bot: I haz the power, 2017-03-20 17:17:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/67435be443d0a9f45d85a0c5a013...