Fix expectations of a few CSP tests with PlzNavigate.

Fix expectations of a few CSP tests with PlzNavigate.

The tests were assuming that the onload event's title change will be received in the browser after the didstoploading IPC. That's not true anymore with PlzNavigate.

BUG=685074
R=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2753203004 .
Cr-Commit-Position: refs/heads/master@{#457891}
Committed: https://chromium.googlesource.com/chromium/src/+/19f804ba738ca0e6133bc19d7ade010208c9a8db

[jam, 2017-03-17 21:00:11]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 21:00:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-17 21:12:27]

Description was changed from

==========
test

BUG=
==========

to

==========
Fix expectations of a few CSP tests with PlzNavigate.

The tests were assuming that the onload event's title change will be received in
the browser after the didstoploading IPC. That's not true anymore with
PlzNavigate.

BUG=685074
==========

[jam, 2017-03-17 21:12:27]

jam@chromium.org changed reviewers:
+ nasko@chromium.org

[nasko, 2017-03-17 21:21:32]

Just one suggestion on flipping the checks around.

https://codereview.chromium.org/2753203004/diff/1/content/browser/site_per_pr...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2753203004/diff/1/content/browser/site_per_pr...
content/browser/site_per_process_browsertest.cc:7501: load_observer2.Wait();
I think it will be slightly better to change the conditions. We know with
PlzNavigate we will commit an error page and in current mode we will not. So
making it if (PlzNavigate) Wait, else EXPECT(not loading) is a bit easier to
understand. It will be easier to clean up too, since we can just get rid of the
else branch and remove the conditional later on.

[nasko, 2017-03-17 21:41:32]

LGTM if the suggestion is done in a follow up.

[jam, 2017-03-17 21:42:56]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-03-17 21:43:00]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-17 21:43:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-17 21:51:27]

Description was changed from

==========
Fix expectations of a few CSP tests with PlzNavigate.

The tests were assuming that the onload event's title change will be received in
the browser after the didstoploading IPC. That's not true anymore with
PlzNavigate.

BUG=685074
==========

to

==========
Fix expectations of a few CSP tests with PlzNavigate.

The tests were assuming that the onload event's title change will be received in
the browser after the didstoploading IPC. That's not true anymore with
PlzNavigate.

BUG=685074
R=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2753203004 .
Cr-Commit-Position: refs/heads/master@{#457891}
Committed:
https://chromium.googlesource.com/chromium/src/+/19f804ba738ca0e6133bc19d7ade...
==========

[jam, 2017-03-17 21:51:29]

Committed patchset #1 (id:1) manually as
19f804ba738ca0e6133bc19d7ade010208c9a8db (presubmit successful).