Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 2753203004: Fix expectations of a few CSP tests with PlzNavigate. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index 98d1eff519c0b12c43d89949b76f09ce7833c6cb..700b4d5a43f5fa02e226151c391fc86b55469e9d 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -7420,7 +7420,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
// Check that the current RenderFrameHost has stopped loading.
if (root->child_at(0)->current_frame_host()->is_loading()) {
- ADD_FAILURE() << "Blocked RenderFrameHost shouldn't be loading anything";
+ if (!IsBrowserSideNavigationEnabled())
+ ADD_FAILURE() << "Blocked RenderFrameHost shouldn't be loading anything";
load_observer.Wait();
}
@@ -7495,7 +7496,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
// Check that the current RenderFrameHost has stopped loading.
if (root->child_at(0)->current_frame_host()->is_loading()) {
- ADD_FAILURE() << "Blocked RenderFrameHost shouldn't be loading anything";
+ if (!IsBrowserSideNavigationEnabled())
+ ADD_FAILURE() << "Blocked RenderFrameHost shouldn't be loading anything";
load_observer2.Wait();
nasko 2017/03/17 21:21:31 I think it will be slightly better to change the c
}
@@ -7564,7 +7566,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
// Check that the current RenderFrameHost has stopped loading.
if (navigating_frame->current_frame_host()->is_loading()) {
- ADD_FAILURE() << "Blocked RenderFrameHost shouldn't be loading anything";
+ if (!IsBrowserSideNavigationEnabled())
+ ADD_FAILURE() << "Blocked RenderFrameHost shouldn't be loading anything";
load_observer2.Wait();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698