Chromium Code Reviews
Help | Chromium Project | Sign in
(22)

Issue 2753033004: Fix resources path for Mac non component build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by dvallet
Modified:
1 month, 1 week ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix resources path for Mac non component build BUG=687407 Review-Url: https://codereview.chromium.org/2753033004 Cr-Commit-Position: refs/heads/master@{#457905} Committed: https://chromium.googlesource.com/chromium/src/+/ade9c19a237e55b6038287ee2ee17fef5529d191

Patch Set 1 #

Patch Set 2 : fixed for non component builds #

Total comments: 2

Patch Set 3 : fixed uppercase #

Messages

Total messages: 24 (17 generated)
dvallet
1 month, 1 week ago (2017-03-17 02:37:30 UTC) #4
Sami
lgtm with a question. https://codereview.chromium.org/2753033004/diff/20001/headless/lib/headless_content_main_delegate.cc File headless/lib/headless_content_main_delegate.cc (right): https://codereview.chromium.org/2753033004/diff/20001/headless/lib/headless_content_main_delegate.cc#newcode254 headless/lib/headless_content_main_delegate.cc:254: dir_module = dir_module.Append(FILE_PATH_LITERAL("resources/")); Should this ...
1 month, 1 week ago (2017-03-17 11:12:01 UTC) #13
dvallet
https://codereview.chromium.org/2753033004/diff/20001/headless/lib/headless_content_main_delegate.cc File headless/lib/headless_content_main_delegate.cc (right): https://codereview.chromium.org/2753033004/diff/20001/headless/lib/headless_content_main_delegate.cc#newcode254 headless/lib/headless_content_main_delegate.cc:254: dir_module = dir_module.Append(FILE_PATH_LITERAL("resources/")); On 2017/03/17 11:12:01, Sami wrote: > ...
1 month, 1 week ago (2017-03-17 19:46:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753033004/40001
1 month, 1 week ago (2017-03-17 19:47:01 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/409544)
1 month, 1 week ago (2017-03-17 22:19:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753033004/40001
1 month, 1 week ago (2017-03-17 22:48:56 UTC) #21
commit-bot: I haz the power
1 month, 1 week ago (2017-03-17 23:56:02 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ade9c19a237e55b6038287ee2ee1...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46