Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2753033004:
Fix resources path for Mac non component build (Closed)
DescriptionFix resources path for Mac non component build
BUG=687407
Review-Url: https://codereview.chromium.org/2753033004
Cr-Commit-Position: refs/heads/master@{#457905}
Committed: https://chromium.googlesource.com/chromium/src/+/ade9c19a237e55b6038287ee2ee17fef5529d191
Patch Set 1 #Patch Set 2 : fixed for non component builds #
Total comments: 2
Patch Set 3 : fixed uppercase #Messages
Total messages: 24 (17 generated)
Description was changed from ========== Added resources/ to path BUG= ========== to ========== https://codereview.chromium.org/2753033004 BUG=687407 ==========
Description was changed from ========== https://codereview.chromium.org/2753033004 BUG=687407 ========== to ========== Fix resources path for Mac non component build BUG=687407 ==========
dvallet@chromium.org changed reviewers: + skyostil@chromium.org
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with a question. https://codereview.chromium.org/2753033004/diff/20001/headless/lib/headless_c... File headless/lib/headless_content_main_delegate.cc (right): https://codereview.chromium.org/2753033004/diff/20001/headless/lib/headless_c... headless/lib/headless_content_main_delegate.cc:254: dir_module = dir_module.Append(FILE_PATH_LITERAL("resources/")); Should this be capitalized? The common pattern I see is Foo.app/Contents/Resources -- assuming this is that resources directory.
https://codereview.chromium.org/2753033004/diff/20001/headless/lib/headless_c... File headless/lib/headless_content_main_delegate.cc (right): https://codereview.chromium.org/2753033004/diff/20001/headless/lib/headless_c... headless/lib/headless_content_main_delegate.cc:254: dir_module = dir_module.Append(FILE_PATH_LITERAL("resources/")); On 2017/03/17 11:12:01, Sami wrote: > Should this be capitalized? The common pattern I see is > Foo.app/Contents/Resources -- assuming this is that resources directory. You're right, funny I just realized that HFS+ is case insensitive
The CQ bit was checked by dvallet@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/2753033004/#ps40001 (title: "fixed uppercase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489790875061930,
"parent_rev": "af74c4fbb6b0c2484f6774febaf58a01c0f0ef38", "commit_rev":
"ade9c19a237e55b6038287ee2ee17fef5529d191"}
Message was sent while issue was closed.
Description was changed from ========== Fix resources path for Mac non component build BUG=687407 ========== to ========== Fix resources path for Mac non component build BUG=687407 Review-Url: https://codereview.chromium.org/2753033004 Cr-Commit-Position: refs/heads/master@{#457905} Committed: https://chromium.googlesource.com/chromium/src/+/ade9c19a237e55b6038287ee2ee1... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ade9c19a237e55b6038287ee2ee1... |
