Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Original CLs:
https://codereview.chromium.org/2693653002/

Notable Changes:
- Fix the bug about std::ostringstream.

BUG=535198, 642290
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2752953002
Cr-Commit-Position: refs/heads/master@{#457277}
Committed: https://chromium.googlesource.com/chromium/src/+/96e2b1d93e12bca0b76edb58a83ec9898dc80962

[dshwang, 2017-03-15 20:53:53]

Description was changed from

==========
Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Original CLs:
https://codereview.chromium.org/2693653002/

Notable Changes:
- Make Nvidia gracefully fail.

BUG=535198, 642290
==========

to

==========
Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Original CLs:
https://codereview.chromium.org/2693653002/

Notable Changes:
- Make Nvidia gracefully fail.

BUG=535198, 642290
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[inactive_dshwang_plz_cc_intel, 2017-03-15 20:54:02]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[inactive_dshwang_plz_cc_intel, 2017-03-15 21:54:43]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 21:55:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dshwang, 2017-03-15 21:58:10]

Description was changed from

==========
Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Original CLs:
https://codereview.chromium.org/2693653002/

Notable Changes:
- Make Nvidia gracefully fail.

BUG=535198, 642290
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Original CLs:
https://codereview.chromium.org/2693653002/

Notable Changes:
- Avoid very strange bug of std::ostringstream.

Following code prints garbage data in debug build, while prints correct string
in release build.
std::ostringstream header << "some glsl code";
const char* source = header.str().c_str();
LOG(ERROR) << source;

However, if holding string data in a local variable, debug build prints correct
string.
std::ostringstream header << "some glsl code";
std::string header_str = header.str();
const char* source = header_str.c_str();
LOG(ERROR) << source;

BUG=535198, 642290
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[dshwang, 2017-03-15 21:59:53]

dongseong.hwang@intel.com changed reviewers:
+ zmo@chromium.org

[dshwang, 2017-03-15 21:59:54]

zmo@chromium.org: could you review to re-land it. The diff to reverted CL is the
diff between patch set 1 and 2.

The Nvidia debug bot failed due to very strange bug of std::ostringstream. I
explain it in the description.

[dshwang, 2017-03-15 22:02:26]

Description was changed from

==========
Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Original CLs:
https://codereview.chromium.org/2693653002/

Notable Changes:
- Avoid very strange bug of std::ostringstream.

Following code prints garbage data in debug build, while prints correct string
in release build.
std::ostringstream header << "some glsl code";
const char* source = header.str().c_str();
LOG(ERROR) << source;

However, if holding string data in a local variable, debug build prints correct
string.
std::ostringstream header << "some glsl code";
std::string header_str = header.str();
const char* source = header_str.c_str();
LOG(ERROR) << source;

BUG=535198, 642290
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Original CLs:
https://codereview.chromium.org/2693653002/

Notable Changes:
- Fix the bug about std::ostringstream.

BUG=535198, 642290
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[dshwang, 2017-03-15 22:05:39]

https://codereview.chromium.org/2752953002/diff/1/gpu/command_buffer/service/...
File
gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
(right):

https://codereview.chromium.org/2752953002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:633:
const char* source_array[4] = {header.str().c_str(), defines, "\n", source};
It's my mistake. std::ostringstream doesn't have a bug.
http://www.cplusplus.com/reference/sstream/ostringstream/str/

header.str() copy string and return string object. this code hold the internal
pointer and then the string object is destructed. It's my bad.

[commit-bot: I haz the power, 2017-03-15 23:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:16:45]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2017-03-15 23:58:46]

On 2017/03/15 22:05:39, dshwang wrote:
>
https://codereview.chromium.org/2752953002/diff/1/gpu/command_buffer/service/...
> File
>
gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
> (right):
> 
>
https://codereview.chromium.org/2752953002/diff/1/gpu/command_buffer/service/...
>
gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:633:
> const char* source_array[4] = {header.str().c_str(), defines, "\n", source};
> It's my mistake. std::ostringstream doesn't have a bug.
> http://www.cplusplus.com/reference/sstream/ostringstream/str/
> 
> header.str() copy string and return string object. this code hold the internal
> pointer and then the string object is destructed. It's my bad.

lgtm

[dshwang, 2017-03-16 00:11:08]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2017-03-16 00:11:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:19:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489623068961900,
"parent_rev": "6810f4a0e51ff154c73f1540772f8b65ce117acd", "commit_rev":
"96e2b1d93e12bca0b76edb58a83ec9898dc80962"}

[commit-bot: I haz the power, 2017-03-16 00:20:39]

Description was changed from

==========
Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Original CLs:
https://codereview.chromium.org/2693653002/

Notable Changes:
- Fix the bug about std::ostringstream.

BUG=535198, 642290
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.

Original CLs:
https://codereview.chromium.org/2693653002/

Notable Changes:
- Fix the bug about std::ostringstream.

BUG=535198, 642290
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2752953002
Cr-Commit-Position: refs/heads/master@{#457277}
Committed:
https://chromium.googlesource.com/chromium/src/+/96e2b1d93e12bca0b76edb58a83e...
==========

[commit-bot: I haz the power, 2017-03-16 00:20:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96e2b1d93e12bca0b76edb58a83e...