Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2752753002: Additional service tests (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update status file for app_jit case #

Patch Set 3 : Introduces helper-ifs instead of copies #

Patch Set 4 : Update to newest source behaviour #

Patch Set 5 : Formatted some tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+780 lines, -114 lines) Patch
M runtime/observatory/tests/service/get_object_rpc_test.dart View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/get_source_report_test.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/next_through_catch_test.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/next_through_for_each_loop_test.dart View 2 chunks +24 lines, -22 lines 0 comments Download
M runtime/observatory/tests/service/next_through_for_loop_with_break_and_continue_test.dart View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/next_through_function_expression_test.dart View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 2 3 4 3 chunks +9 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/service_kernel.status View 1 2 3 4 2 chunks +28 lines, -10 lines 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 1 2 14 chunks +150 lines, -57 lines 0 comments Download
M runtime/observatory/tests/service/set_library_debuggable_test.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A runtime/observatory/tests/service/step_through_arithmetic_test.dart View 1 2 3 4 1 chunk +51 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/step_through_constructor_calls_test.dart View 1 2 3 1 chunk +75 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/step_through_function_2_test.dart View 1 chunk +83 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/step_through_function_test.dart View 1 chunk +108 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/step_through_getter_test.dart View 1 chunk +78 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/step_through_setter_test.dart View 1 chunk +63 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/step_through_switch_test.dart View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jensj
3 years, 9 months ago (2017-03-15 09:16:47 UTC) #2
jensj
Note btw that the .*_kernel_test.dart files are copies of files with the same name expect ...
3 years, 9 months ago (2017-03-15 10:17:52 UTC) #3
Cutch
Hi, Having two copies of tests isn't scalable. I suggest adding a new helper function ...
3 years, 9 months ago (2017-03-15 13:52:47 UTC) #4
jensj
Copies removed.
3 years, 9 months ago (2017-03-16 09:05:58 UTC) #6
jensj
ping.
3 years, 9 months ago (2017-03-21 10:37:58 UTC) #7
Kevin Millikin (Google)
LGTM.
3 years, 9 months ago (2017-03-21 13:33:01 UTC) #8
jensj
3 years, 9 months ago (2017-03-21 13:37:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:100001) manually as
2dbff735223b9a07ce4c5d68bac501448f06d0da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698