Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: runtime/observatory/tests/service/get_object_rpc_test.dart

Issue 2752753002: Additional service tests (Closed)
Patch Set: Formatted some tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/get_source_report_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/get_object_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_object_rpc_test.dart b/runtime/observatory/tests/service/get_object_rpc_test.dart
index e933d4916e62299b2063c61f75cb5fb6cf70b21d..91a3e1112fabc7bfdb15ed21672137c49b21c1f8 100644
--- a/runtime/observatory/tests/service/get_object_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_object_rpc_test.dart
@@ -9,6 +9,7 @@ import 'dart:typed_data';
import 'dart:convert' show BASE64;
import 'package:observatory/service_io.dart';
import 'package:unittest/unittest.dart';
+import 'service_test_common.dart';
import 'test_helper.dart';
class _DummyClass {
@@ -658,8 +659,9 @@ var tests = [
expect(result['uri'], startsWith('file:'));
expect(result['uri'], endsWith('get_object_rpc_test.dart'));
expect(result['debuggable'], equals(true));
- expect(result['dependencies'].length, isPositive);
- expect(result['dependencies'][0]['target']['type'], equals('@Library'));
+ expect(result['dependencies'].length, ifKernel(isZero, isPositive));
+ nonKernelExecute(() => expect(
+ result['dependencies'][0]['target']['type'], equals('@Library')));
expect(result['scripts'].length, isPositive);
expect(result['scripts'][0]['type'], equals('@Script'));
expect(result['variables'].length, isPositive);
@@ -704,7 +706,7 @@ var tests = [
expect(result['id'], startsWith('libraries/'));
expect(result['uri'], startsWith('file:'));
expect(result['uri'], endsWith('get_object_rpc_test.dart'));
- expect(result['_kind'], equals('script'));
+ expect(result['_kind'], equals(ifKernel('kernel', 'script')));
expect(result['library']['type'], equals('@Library'));
expect(result['source'], startsWith('// Copyright (c)'));
expect(result['tokenPosTable'].length, isPositive);
« no previous file with comments | « no previous file | runtime/observatory/tests/service/get_source_report_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698