Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: runtime/observatory/tests/service/service_kernel.status

Issue 2752753002: Additional service tests (Closed)
Patch Set: Formatted some tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/service_kernel.status
diff --git a/runtime/observatory/tests/service/service_kernel.status b/runtime/observatory/tests/service/service_kernel.status
index d1e96b5a535d132b9d345b4cef8ff75b81bcf0fb..a139785e475d2ef5836ddf1523bb42f2b33139e4 100644
--- a/runtime/observatory/tests/service/service_kernel.status
+++ b/runtime/observatory/tests/service/service_kernel.status
@@ -3,18 +3,19 @@
# BSD-style license that can be found in the LICENSE file.
[ $compiler == dartk ]
-add_breakpoint_rpc_test: SkipByDesign # non-kernel specific version of add_breakpoint_rpc_kernel_test
-get_object_rpc_test: SkipByDesign # non-kernel specific. Currently no kernel-specific one exists.
-set_name_rpc_test: SkipByDesign # non-kernel specific. Currently no kernel-specific one exists.
-get_source_report_test: SkipByDesign # non-kernel specific. Currently no kernel-specific one exists.
-debugger_location_test: SkipByDesign # non-kernel specific. Currently no kernel-specific one exists.
-
-next_through_for_each_loop_test: RuntimeError # Test based on source behaviour which just seems wrong
+###
+### Kernel works slightly different. There are kernel specific versions.
+### These are the non-kernel specific versions so skip these tests.
+###
+add_breakpoint_rpc_test: SkipByDesign # non-kernel specific version of add_breakpoint_rpc_kernel_test.
+###
+### Kernel works slightly different. At least for now allow errors.
+###
+library_dependency_test: RuntimeError # There are no imports and exports in kernel.
get_isolate_after_language_error_test: CompileTimeError
developer_extension_test: CompileTimeError
-
-library_dependency_test: RuntimeError # There are no imports and exports in kernel.
+step_through_arithmetic_test: RuntimeError # probably constant evaluator pre-evaluating e.g. 1+2
# These 3 tests fail with 'dart:vmservice_io': error: [...] native function
# 'VMServiceIO_Shutdown' (0 arguments) cannot be found
@@ -28,8 +29,25 @@ address_mapper_test: CompileTimeError
*_reload_*: Skip # no reload support for now
eval_internal_class_test: Skip # no evaluation test for now
evaluate_*: Skip # no evaluation test for now
-causal*: Skip # no causal stack trace test for now
+
+###
+### These tests currently crash the VM
+###
+capture_stdio_test: Crash
+address_mapper_test: Crash
+vm_restart_test: Crash
+rewind_test: RuntimeError # The testee VM crashes.
+
+###
+### --pause-isolates-on-unhandled-exceptions doesn't currently work. Issue #29056
+###
+pause_on_unhandled_async_exceptions2_test: RuntimeError
+pause_on_unhandled_async_exceptions_test: RuntimeError
+
+###
+### Uncategorized.
###
+object_graph_vm_test: RuntimeError
# Inherited from service.status
isolate_lifecycle_test: Pass, RuntimeError
« no previous file with comments | « runtime/observatory/tests/service/service.status ('k') | runtime/observatory/tests/service/service_test_common.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698