chromeos: Enable Alt-Shift-S to show system tray bubble for mash

chromeos: Enable Alt-Shift-S to show system tray bubble for mash

It needed to be moved to the common accelerator handling code.

This fixes SystemTrayTest.Activation in mash_unittests.

BUG=695559, 612331
TEST=ash_unittests, mash_unittests

Review-Url: https://codereview.chromium.org/2752643002
Cr-Commit-Position: refs/heads/master@{#456765}
Committed: https://chromium.googlesource.com/chromium/src/+/6679bd5be3db37cdc4137be13f9c75dde99c2fe4

[James Cook, 2017-03-14 17:15:16]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 17:15:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-03-14 17:16:29]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2017-03-14 17:16:29]

msw, please take a look.

[msw, 2017-03-14 17:25:23]

Nice! lgtm with an aside thought.

https://codereview.chromium.org/2752643002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_unittest.cc (right):

https://codereview.chromium.org/2752643002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_unittest.cc:224: // Closing the bubble
re-activates the window.
aside: Activation changes in unit tests can be flaky, right? (multiple unit
tests run concurrently, but perhaps they're in different ash shell environments,
and the focus/activation isn't shared across test fixtures). I guess if this
hasn't been flaky, then it's okay to leave as-is.

[James Cook, 2017-03-14 17:46:30]

Thanks for the quick review!

https://codereview.chromium.org/2752643002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_unittest.cc (right):

https://codereview.chromium.org/2752643002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_unittest.cc:224: // Closing the bubble
re-activates the window.
On 2017/03/14 17:25:23, msw wrote:
> aside: Activation changes in unit tests can be flaky, right? (multiple unit
> tests run concurrently, but perhaps they're in different ash shell
environments,
> and the focus/activation isn't shared across test fixtures). I guess if this
> hasn't been flaky, then it's okay to leave as-is.

Acknowledged. I think each test gets its own ash::Shell environment.

[James Cook, 2017-03-14 17:46:45]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2017-03-14 17:46:50]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-03-14 17:46:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 18:23:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489513610641600, "parent_rev":
"842efc6922b0cd66febd6f36f04318ebf396c184", "commit_rev":
"6679bd5be3db37cdc4137be13f9c75dde99c2fe4"}

[commit-bot: I haz the power, 2017-03-14 18:24:17]

Description was changed from

==========
chromeos: Enable Alt-Shift-S to show system tray bubble for mash

It needed to be moved to the common accelerator handling code.

This fixes SystemTrayTest.Activation in mash_unittests.

BUG=695559,612331
TEST=ash_unittests, mash_unittests
==========

to

==========
chromeos: Enable Alt-Shift-S to show system tray bubble for mash

It needed to be moved to the common accelerator handling code.

This fixes SystemTrayTest.Activation in mash_unittests.

BUG=695559,612331
TEST=ash_unittests, mash_unittests

Review-Url: https://codereview.chromium.org/2752643002
Cr-Commit-Position: refs/heads/master@{#456765}
Committed:
https://chromium.googlesource.com/chromium/src/+/6679bd5be3db37cdc4137be13f9c...
==========

[commit-bot: I haz the power, 2017-03-14 18:24:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6679bd5be3db37cdc4137be13f9c...