Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2748173002: chromeos: Show deprecated accelerator notifications in mash (Closed)

Created:
3 years, 9 months ago by James Cook
Modified:
3 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Show deprecated accelerator notifications in mash Now that we support mus-aura the code just needed to be moved back to the common accelerator controller. This helps clean up AcceleratorControllerDelegate. No functional changes. BUG=630316 TEST=ash_unittests, Shift-Esc shows deprecated accelerator notification Review-Url: https://codereview.chromium.org/2748173002 Cr-Commit-Position: refs/heads/master@{#456827} Committed: https://chromium.googlesource.com/chromium/src/+/84583c03bdaa1f2070997c4e1a17f4c97639bcec

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -118 lines) Patch
M ash/accelerators/accelerator_controller_delegate_aura.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/accelerators/accelerator_controller_delegate_aura.cc View 4 chunks +0 lines, -88 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 3 chunks +85 lines, -6 lines 0 comments Download
M ash/common/accelerators/accelerator_controller_delegate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_delegate_mus.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_delegate_mus.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
James Cook
msw, please take a look.
3 years, 9 months ago (2017-03-14 17:44:07 UTC) #4
msw
lgtm
3 years, 9 months ago (2017-03-14 18:25:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748173002/20001
3 years, 9 months ago (2017-03-14 20:08:25 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 21:06:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/84583c03bdaa1f2070997c4e1a17...

Powered by Google App Engine
This is Rietveld 408576698