Chromium Code Reviews
DescriptionRevert of Incognito icon added to Windows taskbar jumplist. (patchset #7 id:120001 of https://codereview.chromium.org/2660153002/ )
Reason for revert:
This CL causes a build failure on a bot:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/16181
The error log was:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Win%2F16181%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
FAILED: obj/chrome/chrome_initial/chrome_exe.res
../../chrome/app/chrome_exe.rc(60) : error RC2135 : file not found: theme\google_chrome\win\incognito.ico
Original issue's description:
> Incognito icon added to Windows taskbar jumplist.
>
> On Windows' taskbar's jumplist, both "New window" and "New incognito window" links have main Chrome icon.
> A rough Incognito icon is added to the repository and used instead of Chrome icon for new incognito window link.
>
> BUG=680904
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
>
> Review-Url: https://codereview.chromium.org/2660153002
> Cr-Commit-Position: refs/heads/master@{#457032}
> Committed: https://chromium.googlesource.com/chromium/src/+/596cbc2cc875076c361b1b77e840919a2697b67d
TBR=grt@chromium.org,elawrence@chromium.org,bettes@chromium.org,sky@chromium.org,maxwalker@chromium.org,rhalavati@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680904
Review-Url: https://codereview.chromium.org/2752593004
Cr-Commit-Position: refs/heads/master@{#457037}
Committed: https://chromium.googlesource.com/chromium/src/+/33d538d5169ba8ff274c6cccc9985679bb75746a
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||