Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2752593004: Revert of Incognito icon added to Windows taskbar jumplist. (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, maxwalker
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Incognito icon added to Windows taskbar jumplist. (patchset #7 id:120001 of https://codereview.chromium.org/2660153002/ ) Reason for revert: This CL causes a build failure on a bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/16181 The error log was: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Win%2F16181%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout FAILED: obj/chrome/chrome_initial/chrome_exe.res ../../chrome/app/chrome_exe.rc(60) : error RC2135 : file not found: theme\google_chrome\win\incognito.ico Original issue's description: > Incognito icon added to Windows taskbar jumplist. > > On Windows' taskbar's jumplist, both "New window" and "New incognito window" links have main Chrome icon. > A rough Incognito icon is added to the repository and used instead of Chrome icon for new incognito window link. > > BUG=680904 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > > Review-Url: https://codereview.chromium.org/2660153002 > Cr-Commit-Position: refs/heads/master@{#457032} > Committed: https://chromium.googlesource.com/chromium/src/+/596cbc2cc875076c361b1b77e840919a2697b67d TBR=grt@chromium.org,elawrence@chromium.org,bettes@chromium.org,sky@chromium.org,maxwalker@chromium.org,rhalavati@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=680904 Review-Url: https://codereview.chromium.org/2752593004 Cr-Commit-Position: refs/heads/master@{#457037} Committed: https://chromium.googlesource.com/chromium/src/+/33d538d5169ba8ff274c6cccc9985679bb75746a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M chrome/app/chrome_exe.rc View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/app/theme/chromium/win/incognito.ico View Binary file 0 comments Download
M chrome/browser/win/jumplist.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_icon_resources_win.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_icon_resources_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tzik
Created Revert of Incognito icon added to Windows taskbar jumplist.
3 years, 9 months ago (2017-03-15 08:58:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752593004/1
3 years, 9 months ago (2017-03-15 08:59:18 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 09:00:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33d538d5169ba8ff274c6cccc998...

Powered by Google App Engine
This is Rietveld 408576698