Incognito icon added to Windows taskbar jumplist.

Incognito icon added to Windows taskbar jumplist.

On Windows' taskbar's jumplist, both "New window" and "New incognito window" links have main Chrome icon.
A rough Incognito icon is added to the repository and used instead of Chrome icon for new incognito window link.

BUG=680904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2660153002
Cr-Commit-Position: refs/heads/master@{#457032}
Committed: https://chromium.googlesource.com/chromium/src/+/596cbc2cc875076c361b1b77e840919a2697b67d

[Ramin Halavati, 2017-01-30 13:16:18]

Description was changed from

==========
Incognito icon added to Windows taskbar jumplist.

On Windows' taskbar's jumplist, both "New window" and "New incognito window"
links in have the main Chrome icon.
Incognito icon is added to the repository and used instead of Chrome icon for
new incognito window link.

BUG=680904
==========

to

==========
Incognito icon added to Windows taskbar jumplist.

On Windows' taskbar's jumplist, both "New window" and "New incognito window"
links in have the main Chrome icon.
Incognito icon is added to the repository and used instead of Chrome icon for
new incognito window link.

BUG=680904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[Ramin Halavati, 2017-01-30 13:28:52]

Description was changed from

==========
Incognito icon added to Windows taskbar jumplist.

On Windows' taskbar's jumplist, both "New window" and "New incognito window"
links in have the main Chrome icon.
Incognito icon is added to the repository and used instead of Chrome icon for
new incognito window link.

BUG=680904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Incognito icon added to Windows taskbar jumplist.

On Windows' taskbar's jumplist, both "New window" and "New incognito window"
links have main Chrome icon.
A rough Incognito icon is added to the repository and used instead of Chrome
icon for new incognito window link.

BUG=680904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[Ramin Halavati, 2017-01-30 13:31:22]

rhalavati@chromium.org changed reviewers:
+ cpu@chromium.org, grt@chromium.org

[Ramin Halavati, 2017-01-30 13:31:23]

Please review, and advise for who should I contact for a better icon for
Chromium build and icon in Google-Chrome build.

[grt (UTC plus 2), 2017-01-30 13:55:29]

code changes lgtm. i think the email thread indicated who could help with
getting the proper assets. please land the proper Google Chrome asset before
landing this CL. thanks.

[elawrence, 2017-01-30 16:05:27]

elawrence@chromium.org changed reviewers:
+ elawrence@chromium.org

[elawrence, 2017-01-30 16:05:28]

https://codereview.chromium.org/2660153002/diff/1/chrome/browser/win/jumplist.cc
File chrome/browser/win/jumplist.cc (right):

https://codereview.chromium.org/2660153002/diff/1/chrome/browser/win/jumplist...
chrome/browser/win/jumplist.cc:141: // add it to the collection. We use our
application icon as the icon for
Comment is now out of date, and the second sentence can probably be removed now
because the code is clear about the behavior.

[Ramin Halavati, 2017-01-31 07:02:09]

rhalavati@chromium.org changed reviewers:
+ bettes@chromium.org

[Ramin Halavati, 2017-01-31 07:02:10]

All comments addressed.

Alen, please review the icon.

https://codereview.chromium.org/2660153002/diff/1/chrome/browser/win/jumplist.cc
File chrome/browser/win/jumplist.cc (right):

https://codereview.chromium.org/2660153002/diff/1/chrome/browser/win/jumplist...
chrome/browser/win/jumplist.cc:141: // add it to the collection. We use our
application icon as the icon for
On 2017/01/30 16:05:28, elawrence wrote:
> Comment is now out of date, and the second sentence can probably be removed
now
> because the code is clear about the behavior.

Done.

[Ramin Halavati, 2017-02-01 06:08:40]

cpu@, a friendly ping.

Bests,
Ramin

[grt (UTC plus 2), 2017-02-01 12:42:27]

On 2017/02/01 06:08:40, Ramin Halavati wrote:
> cpu@, a friendly ping.

Please pick an OWNER from src/chrome/OWNERS for the files in src/chrome/common.

[Ramin Halavati, 2017-02-01 12:51:41]

rhalavati@chromium.org changed reviewers:
+ pkasting@chromium.org
- cpu@chromium.org

[Ramin Halavati, 2017-02-01 12:51:41]

Thanks grt@.

pkasting@: Please review chrome_icon_resources_win.h and
chrome_icon_resources_win.cc.

[grt (UTC plus 2), 2017-02-01 12:53:50]

On 2017/02/01 12:51:41, Ramin Halavati wrote:
> Thanks grt@.
> 
> pkasting@: Please review chrome_icon_resources_win.h and
> chrome_icon_resources_win.cc.

PK doesn't appear to be an owner in src/chrome.

[Ramin Halavati, 2017-02-01 13:09:23]

rhalavati@chromium.org changed reviewers:
+ sky@chromium.org
- pkasting@chromium.org

[Ramin Halavati, 2017-02-01 13:09:24]

sky@: Could you please review chrome_icon_resources_win.h and
chrome_icon_resources_win.cc.

pkasting@: Sorry for the wrong email.

[Ramin Halavati, 2017-02-01 13:22:51]

Resource file updated for Google Chrome build.

[grt (UTC plus 2), 2017-02-01 13:28:50]

https://codereview.chromium.org/2660153002/diff/40001/chrome/app/chrome_exe.rc
File chrome/app/chrome_exe.rc (right):

https://codereview.chromium.org/2660153002/diff/40001/chrome/app/chrome_exe.r...
chrome/app/chrome_exe.rc:60: // TODO(rhalavati@): To be changed before landing
this CL.
remove comment?

https://codereview.chromium.org/2660153002/diff/40001/chrome/app/chrome_exe.r...
chrome/app/chrome_exe.rc:61: IDR_X003_INCOGNITO      ICON                   
"theme\\google_chrome\\win\\incognito.ico"
do you have a CL that adds this file? is the asset different between Chromium
and Google Chrome?

[Ramin Halavati, 2017-02-01 13:44:13]

Comments addressed. Please review.

https://codereview.chromium.org/2660153002/diff/40001/chrome/app/chrome_exe.rc
File chrome/app/chrome_exe.rc (right):

https://codereview.chromium.org/2660153002/diff/40001/chrome/app/chrome_exe.r...
chrome/app/chrome_exe.rc:60: // TODO(rhalavati@): To be changed before landing
this CL.
On 2017/02/01 13:28:50, grt (UTC plus 1) wrote:
> remove comment?

Done.

https://codereview.chromium.org/2660153002/diff/40001/chrome/app/chrome_exe.r...
chrome/app/chrome_exe.rc:61: IDR_X003_INCOGNITO      ICON                   
"theme\\google_chrome\\win\\incognito.ico"
On 2017/02/01 13:28:50, grt (UTC plus 1) wrote:
> do you have a CL that adds this file? is the asset different between Chromium
> and Google Chrome?

I am waiting for the icon to be verified by bettes@. In case similar icons would
be used, should I include it from Chromium directory or put a new one here?

[sky, 2017-02-01 16:50:49]

LGTM

[grt (UTC plus 2), 2017-02-01 21:01:21]

lgtm % order-of-landing comment below

https://codereview.chromium.org/2660153002/diff/40001/chrome/app/chrome_exe.rc
File chrome/app/chrome_exe.rc (right):

https://codereview.chromium.org/2660153002/diff/40001/chrome/app/chrome_exe.r...
chrome/app/chrome_exe.rc:61: IDR_X003_INCOGNITO      ICON                   
"theme\\google_chrome\\win\\incognito.ico"
On 2017/02/01 13:44:13, Ramin Halavati wrote:
> On 2017/02/01 13:28:50, grt (UTC plus 1) wrote:
> > do you have a CL that adds this file? is the asset different between
Chromium
> > and Google Chrome?
> 
> I am waiting for the icon to be verified by bettes@. In case similar icons
would
> be used, should I include it from Chromium directory or put a new one here?

If the icon is truly identical, maybe it should be in neither the chromium nor
google_chrome directories. Do we have cross-brand icons in the tree anywhere?
Otherwise, if keeping the icons in brand-specific directories makes sense, take
care to land the google_chrome icon before landing this CL. Otherwise you may
break Google Chrome-branded builds (file not found when running rc.exe on this
file).

[Ramin Halavati, 2017-02-02 05:28:44]

ainslie@, could you please comment on this? We want to add an icon for incognito
new window and it's similar for Chromium and Google Chrome themes, should we
have two copies of it in different theme directories? Or it shouldn't be similar
at all? I've created one in this CL and bettes@ is reviewing it.

bettes@: A friendly ping on icon review.

[Ramin Halavati, 2017-02-07 06:08:39]

Hi Max, Alen,

This CL is blocked for icon approval. Can I do anything to facilitate it?

Bests,
Ramin

[chromium-reviews, 2017-02-07 20:00:20]

Any guidance from you or Windows on asset sizing and exports?

On Mon, Feb 6, 2017 at 10:08 PM, <rhalavati@chromium.org> wrote:

> Hi Max, Alen,
>
> This CL is blocked for icon approval. Can I do anything to facilitate it?
>
> Bests,
> Ramin
>
> https://codereview.chromium.org/2660153002/
>



-- 
Alan Bettes
Visual Designer / Chrome

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-02-07 20:09:12]

I think it can be similar to the main icon as it was used instead of
incognito until now.

On Feb 7, 2017 21:00, "Alan Bettes" <bettes@google.com> wrote:

Any guidance from you or Windows on asset sizing and exports?

On Mon, Feb 6, 2017 at 10:08 PM, <rhalavati@chromium.org> wrote:

> Hi Max, Alen,
>
> This CL is blocked for icon approval. Can I do anything to facilitate it?
>
> Bests,
> Ramin
>
> https://codereview.chromium.org/2660153002/
>



-- 
Alan Bettes
Visual Designer / Chrome

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ramin Halavati, 2017-02-22 14:56:12]

rhalavati@chromium.org changed reviewers:
+ maxwalker@chromium.org

[Ramin Halavati, 2017-02-22 14:56:12]

Thanks Alan.

maxwalker@:
I used the white incognito icon as the menu background in windows is dark by
default. Is it OK?

I've created this CL (https://chromereviews.googleplex.com/573787013/) to upload
icon to branded repository.

[chromium-reviews, 2017-02-24 09:34:13]

Hi Alan,

Could you please send another set where background is black and foreground
is white (May be dark circle and light incgonito sign)? Transparent
background would not be good for Windows 7.

Bests,
Ramin

On Wed, Feb 22, 2017 at 3:56 PM, <rhalavati@chromium.org> wrote:

> Thanks Alan.
>
> maxwalker@:
> I used the white incognito icon as the menu background in windows is dark
> by
> default. Is it OK?
>
> I've created this CL (https://chromereviews.googleplex.com/573787013/) to
> upload
> icon to branded repository.
>
> https://codereview.chromium.org/2660153002/
>

Ramin Halavati

Software Engineer

rhalavati@google.com
+49 151 46921250

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
dass die E-Mail an die falsche Person gesendet wurde.


This e-mail is confidential. If you received this communication by mistake,
please don't forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-03-02 06:05:43]

Hi Alan,

This bug is still waiting for you.

Bests,
Ramin

On Fri, Feb 24, 2017 at 10:33 AM, Ramin Halavati <rhalavati@google.com>
wrote:

> Hi Alan,
>
> Could you please send another set where background is black and foreground
> is white (May be dark circle and light incgonito sign)? Transparent
> background would not be good for Windows 7.
>
> Bests,
> Ramin
>
> On Wed, Feb 22, 2017 at 3:56 PM, <rhalavati@chromium.org> wrote:
>
>> Thanks Alan.
>>
>> maxwalker@:
>> I used the white incognito icon as the menu background in windows is dark
>> by
>> default. Is it OK?
>>
>> I've created this CL (https://chromereviews.googleplex.com/573787013/)
>> to upload
>> icon to branded repository.
>>
>> https://codereview.chromium.org/2660153002/
>>
>
> Ramin Halavati
>
> Software Engineer
>
> rhalavati@google.com
> +49 151 46921250 <+49%201514%206921250>
>
> Google Germany GmbH
>
> Erika-Mann-Straße 33
>
> 80636 München
>
> Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
>
> Registergericht und -nummer: Hamburg, HRB 86891
>
> Sitz der Gesellschaft: Hamburg
>
> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
> dass die E-Mail an die falsche Person gesendet wurde.
>
>
> This e-mail is confidential. If you received this communication by
> mistake, please don't forward it to anyone else, please erase all copies
> and attachments, and please let me know that it has gone to the wrong
> person.
>

Ramin Halavati

Software Engineer

rhalavati@google.com
+49 151 46921250

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
dass die E-Mail an die falsche Person gesendet wurde.


This e-mail is confidential. If you received this communication by mistake,
please don't forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-03-02 18:28:15]

Emailed you privately

On Wed, Mar 1, 2017 at 10:05 PM, Ramin Halavati <rhalavati@google.com>
wrote:

> Hi Alan,
>
> This bug is still waiting for you.
>
> Bests,
> Ramin
>
>
> On Fri, Feb 24, 2017 at 10:33 AM, Ramin Halavati <rhalavati@google.com>
> wrote:
>
>> Hi Alan,
>>
>> Could you please send another set where background is black and
>> foreground is white (May be dark circle and light incgonito sign)?
>> Transparent background would not be good for Windows 7.
>>
>> Bests,
>> Ramin
>>
>> On Wed, Feb 22, 2017 at 3:56 PM, <rhalavati@chromium.org> wrote:
>>
>>> Thanks Alan.
>>>
>>> maxwalker@:
>>> I used the white incognito icon as the menu background in windows is
>>> dark by
>>> default. Is it OK?
>>>
>>> I've created this CL (https://chromereviews.googleplex.com/573787013/)
>>> to upload
>>> icon to branded repository.
>>>
>>> https://codereview.chromium.org/2660153002/
>>>
>>
>> Ramin Halavati
>>
>> Software Engineer
>>
>> rhalavati@google.com
>> +49 151 46921250 <+49%201514%206921250>
>>
>> Google Germany GmbH
>>
>> Erika-Mann-Straße 33
>>
>> 80636 München
>>
>> Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
>>
>> Registergericht und -nummer: Hamburg, HRB 86891
>>
>> Sitz der Gesellschaft: Hamburg
>>
>> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
>> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
>> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
>> dass die E-Mail an die falsche Person gesendet wurde.
>>
>>
>> This e-mail is confidential. If you received this communication by
>> mistake, please don't forward it to anyone else, please erase all copies
>> and attachments, and please let me know that it has gone to the wrong
>> person.
>>
>
> Ramin Halavati
>
> Software Engineer
>
> rhalavati@google.com
> +49 151 46921250 <+49%201514%206921250>
>
> Google Germany GmbH
>
> Erika-Mann-Straße 33
>
> 80636 München
>
> Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
>
> Registergericht und -nummer: Hamburg, HRB 86891
>
> Sitz der Gesellschaft: Hamburg
>
> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
> dass die E-Mail an die falsche Person gesendet wurde.
>
>
> This e-mail is confidential. If you received this communication by
> mistake, please don't forward it to anyone else, please erase all copies
> and attachments, and please let me know that it has gone to the wrong
> person.
>



-- 
Alan Bettes
Visual Designer / Chrome

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ramin Halavati, 2017-03-15 06:22:42]

The CQ bit was checked by rhalavati@chromium.org

[Ramin Halavati, 2017-03-15 06:22:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
grt@chromium.org
Link to the patchset: https://codereview.chromium.org/2660153002/#ps120001
(title: "Incognito icon added back.")

[commit-bot: I haz the power, 2017-03-15 06:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 08:22:53]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489558962427280,
"parent_rev": "c138025d59a66894f203432e08f0a92061297ec6", "commit_rev":
"596cbc2cc875076c361b1b77e840919a2697b67d"}

[commit-bot: I haz the power, 2017-03-15 08:23:42]

Description was changed from

==========
Incognito icon added to Windows taskbar jumplist.

On Windows' taskbar's jumplist, both "New window" and "New incognito window"
links have main Chrome icon.
A rough Incognito icon is added to the repository and used instead of Chrome
icon for new incognito window link.

BUG=680904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Incognito icon added to Windows taskbar jumplist.

On Windows' taskbar's jumplist, both "New window" and "New incognito window"
links have main Chrome icon.
A rough Incognito icon is added to the repository and used instead of Chrome
icon for new incognito window link.

BUG=680904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2660153002
Cr-Commit-Position: refs/heads/master@{#457032}
Committed:
https://chromium.googlesource.com/chromium/src/+/596cbc2cc875076c361b1b77e840...
==========

[commit-bot: I haz the power, 2017-03-15 08:23:43]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/596cbc2cc875076c361b1b77e840...

[tzik, 2017-03-15 08:58:29]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2752593004/ by tzik@chromium.org.

The reason for reverting is: This CL causes a build failure on a bot:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

The error log was:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle...
FAILED: obj/chrome/chrome_initial/chrome_exe.res 
../../chrome/app/chrome_exe.rc(60) : error RC2135 : file not found:
theme\google_chrome\win\incognito.ico
.

[Henrik Grunell, 2017-03-15 08:59:43]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2747283003/ by grunell@chromium.org.

The reason for reverting is: Broke official builder.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle...

[13782/39069] RC obj/chrome/chrome_initial/chrome_exe.res
FAILED: obj/chrome/chrome_initial/chrome_exe.res 
C:/b/depot_tools/python276_bin/python.exe
../../build/toolchain/win/tool_wrapper.py rc-wrapper environment.x86 rc.exe
-DCHROME_MULTIPLE_DLL -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -D__STD_C
-D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_HAS_EXCEPTIONS=0
-D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS
-DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL
-D_USING_V110_SDK71_ -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE
-DNTDDI_VERSION=0x0A000000 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCOMPILE_CONTENT_STATICALLY -I../..
-Igen -I../../breakpad/src -I../../breakpad/src
-I../../third_party/boringssl/src/include
/foobj/chrome/chrome_initial/chrome_exe.res ../../chrome/app/chrome_exe.rc
../../chrome/app/chrome_exe.rc(60) : error RC2135 : file not found:
theme\google_chrome\win\incognito.ico
.

[Ramin Halavati, 2017-03-15 09:00:44]

On 2017/03/15 08:59:43, Henrik Grunell wrote:
> A revert of this CL (patchset #7 id:120001) has been created in
> https://codereview.chromium.org/2747283003/ by mailto:grunell@chromium.org.
> 
> The reason for reverting is: Broke official builder.
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle...
> 
> [13782/39069] RC obj/chrome/chrome_initial/chrome_exe.res
> FAILED: obj/chrome/chrome_initial/chrome_exe.res 
> C:/b/depot_tools/python276_bin/python.exe
> ../../build/toolchain/win/tool_wrapper.py rc-wrapper environment.x86 rc.exe
> -DCHROME_MULTIPLE_DLL -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC
> -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
> -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -D__STD_C
> -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_HAS_EXCEPTIONS=0
> -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS
> -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL
> -D_USING_V110_SDK71_ -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE
> -DNTDDI_VERSION=0x0A000000 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG
> -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCOMPILE_CONTENT_STATICALLY
-I../..
> -Igen -I../../breakpad/src -I../../breakpad/src
> -I../../third_party/boringssl/src/include
> /foobj/chrome/chrome_initial/chrome_exe.res ../../chrome/app/chrome_exe.rc
> ../../chrome/app/chrome_exe.rc(60) : error RC2135 : file not found:
> theme\google_chrome\win\incognito.ico
> .

I had added the icon in this CL: https://chromereviews.googleplex.com/573787013/
Could you please point what I have done wrong and how should I correct it?

[grt (UTC plus 2), 2017-03-15 09:05:00]

On 2017/03/15 09:00:44, Ramin Halavati wrote:
> On 2017/03/15 08:59:43, Henrik Grunell wrote:
> > A revert of this CL (patchset #7 id:120001) has been created in
> > https://codereview.chromium.org/2747283003/ by mailto:grunell@chromium.org.
> > 
> > The reason for reverting is: Broke official builder.
> > 
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle...
> > 
> > [13782/39069] RC obj/chrome/chrome_initial/chrome_exe.res
> > FAILED: obj/chrome/chrome_initial/chrome_exe.res 
> > C:/b/depot_tools/python276_bin/python.exe
> > ../../build/toolchain/win/tool_wrapper.py rc-wrapper environment.x86 rc.exe
> > -DCHROME_MULTIPLE_DLL -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC
> > -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
> > -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -D__STD_C
> > -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_HAS_EXCEPTIONS=0
> > -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS
> > -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL
> > -D_USING_V110_SDK71_ -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE
> > -DNTDDI_VERSION=0x0A000000 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG
> > -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCOMPILE_CONTENT_STATICALLY
> -I../..
> > -Igen -I../../breakpad/src -I../../breakpad/src
> > -I../../third_party/boringssl/src/include
> > /foobj/chrome/chrome_initial/chrome_exe.res ../../chrome/app/chrome_exe.rc
> > ../../chrome/app/chrome_exe.rc(60) : error RC2135 : file not found:
> > theme\google_chrome\win\incognito.ico
> > .
> 
> I had added the icon in this CL:
https://chromereviews.googleplex.com/573787013/
> Could you please point what I have done wrong and how should I correct it?

Your change requires a DEPS roll; see
https://chromereviews.googleplex.com/490537013 for an example.