Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2752593003: Migrate WTF::Deque::first() to ::front() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
Mads Ager (chromium), ajuma+watch_chromium.org, ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, kouhei+heap_chromium.org, loading-reviews+parser_chromium.org, Mikhail, Navid Zolghadr, oilpan-reviews, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, sof, tyoshino+watch_chromium.org, yhirano+watch_chromium.org, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Deque::first() to ::front() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2752593003 Cr-Commit-Position: refs/heads/master@{#456798} Committed: https://chromium.googlesource.com/chromium/src/+/2c5469af36b09c670cc19ddd589b09bc14008210

Patch Set 1 #

Patch Set 2 : one more platform specific reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -53 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/DequeTest.cpp View 5 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
pilgrim_google
3 years, 9 months ago (2017-03-14 16:57:02 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-14 17:00:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752593003/1
3 years, 9 months ago (2017-03-14 17:01:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/373621)
3 years, 9 months ago (2017-03-14 17:16:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752593003/20001
3 years, 9 months ago (2017-03-14 17:41:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/383153)
3 years, 9 months ago (2017-03-14 18:48:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752593003/20001
3 years, 9 months ago (2017-03-14 19:09:38 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 19:58:31 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c5469af36b09c670cc19ddd589b...

Powered by Google App Engine
This is Rietveld 408576698