Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

Issue 2752593003: Migrate WTF::Deque::first() to ::front() (Closed)
Patch Set: one more platform specific reference Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
index 13e32ead8ebeace02643cf93e363a96ccb77a171..083b9192e47d7689d69844eb54c8ec29edec85a3 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
@@ -367,7 +367,7 @@ void HTMLParserScriptRunner::pendingScriptFinished(
if (pendingScript == parserBlockingScript()) {
m_parserBlockingScript = nullptr;
} else {
- CHECK_EQ(pendingScript, m_scriptsToExecuteAfterParsing.first());
+ CHECK_EQ(pendingScript, m_scriptsToExecuteAfterParsing.front());
// TODO(hiroshige): Remove this CHECK() before going to beta.
// This is only to make clusterfuzz to find a test case that executes
@@ -505,18 +505,18 @@ bool HTMLParserScriptRunner::executeScriptsWaitingForParsing() {
while (!m_scriptsToExecuteAfterParsing.isEmpty()) {
DCHECK(!isExecutingScript());
DCHECK(!hasParserBlockingScript());
- DCHECK(m_scriptsToExecuteAfterParsing.first()->resource());
+ DCHECK(m_scriptsToExecuteAfterParsing.front()->resource());
// 1. "Spin the event loop until the first script in the list of scripts
// that will execute when the document has finished parsing
// has its "ready to be parser-executed" flag set and
// the parser's Document has no style sheet that is blocking scripts."
// TODO(hiroshige): Is the latter part checked anywhere?
- if (!m_scriptsToExecuteAfterParsing.first()->isReady()) {
- m_scriptsToExecuteAfterParsing.first()->watchForLoad(this);
- traceParserBlockingScript(m_scriptsToExecuteAfterParsing.first().get(),
+ if (!m_scriptsToExecuteAfterParsing.front()->isReady()) {
+ m_scriptsToExecuteAfterParsing.front()->watchForLoad(this);
+ traceParserBlockingScript(m_scriptsToExecuteAfterParsing.front().get(),
!m_document->isScriptExecutionReady());
- m_scriptsToExecuteAfterParsing.first()->markParserBlockingLoadStartTime();
+ m_scriptsToExecuteAfterParsing.front()->markParserBlockingLoadStartTime();
return false;
}

Powered by Google App Engine
This is Rietveld 408576698