cc: Make PaintCanvas abstract

cc: Make PaintCanvas abstract

This is for the goal of having a separate implementation for recording
vs pass through to Skia.  Right now, there's only a single
implementation of PaintCanvas (SkiaPaintCanvas), but a newer
RecordPaintCanvas will be added after this patch that PaintRecorder
will use.

Virtualization here adds a little bit of overhead (0.5% record time on
linux 10k), but should be able to be recovered in future patches.
There's not much option here in terms of how to stage this patch, so
this regression will just need to be eaten in the short term.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2752593002
Cr-Commit-Position: refs/heads/master@{#457169}
Committed: https://chromium.googlesource.com/chromium/src/+/98c9f805b64f60e6dc4a0b305d09a176b4eb105d

[enne (OOO), 2017-03-14 01:06:22]

Description was changed from

==========
[wip] abstract paintcanvas
==========

to

==========
[wip] abstract paintcanvas
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-14 01:06:24]

Description was changed from

==========
[wip] abstract paintcanvas
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[wip] abstract paintcanvas
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-14 17:45:23]

Description was changed from

==========
[wip] abstract paintcanvas
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc: Make PaintCanvas abstract

This is for the goal of having a separate implementation for recording
vs pass through to Skia.  Right now, there's only a single
implementation of PaintCanvas (SkiaPaintCanvas), but a newer
RecordPaintCanvas will be added after this patch that PaintRecorder
will use.

Virtualization here adds a little bit of overhead (0.5% record time on
linux 10k), but should be able to be recovered in future patches.
There's not much option here in terms of how to stage this patch, so
this regression will just need to be eaten in the short term.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-14 17:45:23]

enne@chromium.org changed reviewers:
+ vmpstr@chromium.org

[enne (OOO), 2017-03-14 17:45:32]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 17:45:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-03-14 17:48:56]

enne@chromium.org changed reviewers:
+ nick@chromium.org, pdr@chromium.org, vitalybuka@chromium.org,
watk@chromium.org

[enne (OOO), 2017-03-14 17:50:10]

vmpstr: cc and overall patch

Mostly mechanical owners reviews:
nick: content/
pdr: Blink
watk: media/

https://codereview.chromium.org/2752593002/diff/20001/content/renderer/pepper...
File content/renderer/pepper/pepper_graphics_2d_host_unittest.cc (left):

https://codereview.chromium.org/2752593002/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_graphics_2d_host_unittest.cc:74: void
PaintToWebCanvas(SkBitmap* bitmap) {
I went to change this to SkiaPaintCanvas, but it appears unused, so removed it.

[pdr., 2017-03-14 17:52:56]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-14 18:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 18:00:19]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ncarter (slow), 2017-03-14 18:00:33]

content lgtm

https://codereview.chromium.org/2752593002/diff/20001/content/renderer/pepper...
File content/renderer/pepper/pepper_graphics_2d_host_unittest.cc (left):

https://codereview.chromium.org/2752593002/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_graphics_2d_host_unittest.cc:74: void
PaintToWebCanvas(SkBitmap* bitmap) {
On 2017/03/14 17:50:10, enne wrote:
> I went to change this to SkiaPaintCanvas, but it appears unused, so removed
it.

Even better.

[pdr., 2017-03-14 18:12:49]

Mechanical work in blink LGTM.

Deferring to vmpstr for a real review.

[enne (OOO), 2017-03-14 18:23:52]

Description was changed from

==========
cc: Make PaintCanvas abstract

This is for the goal of having a separate implementation for recording
vs pass through to Skia.  Right now, there's only a single
implementation of PaintCanvas (SkiaPaintCanvas), but a newer
RecordPaintCanvas will be added after this patch that PaintRecorder
will use.

Virtualization here adds a little bit of overhead (0.5% record time on
linux 10k), but should be able to be recovered in future patches.
There's not much option here in terms of how to stage this patch, so
this regression will just need to be eaten in the short term.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc: Make PaintCanvas abstract

This is for the goal of having a separate implementation for recording
vs pass through to Skia.  Right now, there's only a single
implementation of PaintCanvas (SkiaPaintCanvas), but a newer
RecordPaintCanvas will be added after this patch that PaintRecorder
will use.

Virtualization here adds a little bit of overhead (0.5% record time on
linux 10k), but should be able to be recovered in future patches.
There's not much option here in terms of how to stage this patch, so
this regression will just need to be eaten in the short term.

BUG=671433

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-14 18:23:53]

enne@chromium.org changed reviewers:
- chrishtr@chromium.org

[enne (OOO), 2017-03-14 18:26:53]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 18:27:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Vitaly Buka (NO REVIEWS), 2017-03-14 18:54:31]

printing/ LGTM

[commit-bot: I haz the power, 2017-03-14 20:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:29:25]

Dry run: This issue passed the CQ dry run.

[watk, 2017-03-14 23:44:59]

media lgtm

[enne (OOO), 2017-03-15 17:51:46]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 17:52:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-03-15 18:14:13]

lgtm, I think this looks really good!

[enne (OOO), 2017-03-15 18:15:55]

The CQ bit was unchecked by enne@chromium.org

[enne (OOO), 2017-03-15 18:15:58]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2017-03-15 18:15:59]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org,
pdr@chromium.org, watk@chromium.org, vitalybuka@chromium.org
Link to the patchset: https://codereview.chromium.org/2752593002/#ps80001
(title: "Remove default parameters on virtual functions")

[commit-bot: I haz the power, 2017-03-15 18:16:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 19:38:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489601758242010,
"parent_rev": "3de53e557c2b84aed1cb4ba9ed1133ac361da46c", "commit_rev":
"98c9f805b64f60e6dc4a0b305d09a176b4eb105d"}

[commit-bot: I haz the power, 2017-03-15 19:39:09]

Description was changed from

==========
cc: Make PaintCanvas abstract

This is for the goal of having a separate implementation for recording
vs pass through to Skia.  Right now, there's only a single
implementation of PaintCanvas (SkiaPaintCanvas), but a newer
RecordPaintCanvas will be added after this patch that PaintRecorder
will use.

Virtualization here adds a little bit of overhead (0.5% record time on
linux 10k), but should be able to be recovered in future patches.
There's not much option here in terms of how to stage this patch, so
this regression will just need to be eaten in the short term.

BUG=671433

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc: Make PaintCanvas abstract

This is for the goal of having a separate implementation for recording
vs pass through to Skia.  Right now, there's only a single
implementation of PaintCanvas (SkiaPaintCanvas), but a newer
RecordPaintCanvas will be added after this patch that PaintRecorder
will use.

Virtualization here adds a little bit of overhead (0.5% record time on
linux 10k), but should be able to be recovered in future patches.
There's not much option here in terms of how to stage this patch, so
this regression will just need to be eaten in the short term.

BUG=671433

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2752593002
Cr-Commit-Position: refs/heads/master@{#457169}
Committed:
https://chromium.googlesource.com/chromium/src/+/98c9f805b64f60e6dc4a0b305d09...
==========

[commit-bot: I haz the power, 2017-03-15 19:39:11]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/98c9f805b64f60e6dc4a0b305d09...