Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2752563002: Add generated CSSPropertyAPIFragmentation.h file to core/BUILD.gn (Closed)

Created:
3 years, 9 months ago by nainar
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add generated CSSPropertyAPIFragmentation.h file to core/BUILD.gn Follow up to https://codereview.chromium.org/2639303004 BUG=668012 Review-Url: https://codereview.chromium.org/2752563002 Cr-Commit-Position: refs/heads/master@{#462689} Committed: https://chromium.googlesource.com/chromium/src/+/9b7ef119f3fccf1aecf18202637ae3d36abda692

Patch Set 1 #

Patch Set 2 : Add generated CSSPropertyAPIFragmentation.h file to core/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
nainar
PTAL? Thanks!
3 years, 9 months ago (2017-03-13 23:57:13 UTC) #4
nainar
Alan, PTAL?
3 years, 9 months ago (2017-03-14 00:03:51 UTC) #6
alancutter (OOO until 2018)
lgtm
3 years, 9 months ago (2017-03-14 00:15:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752563002/20001
3 years, 9 months ago (2017-03-16 04:22:42 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/327943)
3 years, 9 months ago (2017-03-16 04:51:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752563002/20001
3 years, 8 months ago (2017-04-06 21:23:46 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9b7ef119f3fccf1aecf18202637ae3d36abda692
3 years, 8 months ago (2017-04-06 23:52:46 UTC) #23
Bugs Nash
3 years, 8 months ago (2017-04-07 00:01:00 UTC) #24
Message was sent while issue was closed.
On 2017/04/06 at 23:52:46, commit-bot wrote:
> Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9b7ef119f3fccf1aecf18202637a...

Thanks for cleaning that up :)

Powered by Google App Engine
This is Rietveld 408576698