Implements CSSPropertyAPI for the fragmentation element properties.

Implements CSSPropertyAPI for the fragmentation element properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWidows, CSSPropertyOrphans and 
CSSPropertyWebkitFragmentationOrdinalGroup from the switch statement in 
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
border radius properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIFragmentationGroup.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPIFragmentationGroup flag to each fragmentation class 
  property in CSSProperties.in, which indicates that 
  CSSPropertyAPIFragmentationGroup.h is generated.
- Moves the parsing logic for fragmentation properties from CSSPropertyParser.cpp
  to CSSPropertyAPIFragmentationGroup.cpp, which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2639303004
Cr-Commit-Position: refs/heads/master@{#456320}
Committed: https://chromium.googlesource.com/chromium/src/+/b5e82dce09c880f7aa92a7a2203dc4b0e64c0e84

[nainar, 2017-01-18 23:40:57]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[nainar, 2017-01-18 23:41:24]

nainar@chromium.org changed reviewers:
+ aazzam@google.com

[nainar, 2017-01-18 23:41:25]

Hi Anna, 

PTAL? Thanks! :)

[commit-bot: I haz the power, 2017-01-18 23:41:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-01-18 23:53:29]

Description was changed from

==========
Implements CSSPropertyAPI for the widows property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWidows from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
widows property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWidows.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWidows.h is generated.
- Moves the parsing logic for widows from CSSPropertyParser.cpp to
  CSSPropertyAPIWidows.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the box element properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWidows, CSSPropertyOrphans and 
CSSPropertyWebkitBoxOrdinalGroup from the switch statement in 
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
border radius properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIBoxGroup.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPIBoxGroup flag to each border class 
  property in CSSProperties.in, which indicates that 
  CSSPropertyAPIBoxGroup.h is generated.
- Moves the parsing logic for border radius from CSSPropertyParser.cpp
  to CSSPropertyAPIBoxGroup.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[nainar, 2017-01-18 23:53:36]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:54:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-01-18 23:56:30]

Sending back per feedback

https://codereview.chromium.org/2639303004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (left):

https://codereview.chromium.org/2639303004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3274: case
CSSPropertyWidows:
As per IRL conversation grouping together properties widows, orphans and
webkit-box-ordinal-group.

[commit-bot: I haz the power, 2017-01-18 23:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:57:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[aazzam, 2017-01-19 00:01:51]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-19 00:01:52]

lgtm with comment! sasha ptal :)

https://codereview.chromium.org/2639303004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBoxGroup.cpp
(right):

https://codereview.chromium.org/2639303004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBoxGroup.cpp:7:
#include "core/css/parser/CSSParserContext.h"
not sure if this include is needed

[nainar, 2017-01-19 00:15:23]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:16:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-19 00:41:59]

https://codereview.chromium.org/2639303004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/BUILD.gn (right):

https://codereview.chromium.org/2639303004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/BUILD.gn:345: "parser/SizesCalcParser.cpp",
Typo in CL description in the bullet points bit - each 'box' class :) and then
the parsing logic for 'box properties'

https://codereview.chromium.org/2639303004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBoxGroup.cpp
(right):

https://codereview.chromium.org/2639303004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBoxGroup.cpp:11:
const CSSValue* CSSPropertyAPIBoxGroup::parseSingleValue(
The naming of this one is hard. 'Widows' and 'orphans' are defined in
Fragmentation L3 https://drafts.csswg.org/css-break-3/#widows-orphans, and
box-ordinal-group is not defined at all (although MDN has a page on it here
claiming its part of flexbox -
https://developer.mozilla.org/en-US/docs/Web/CSS/box-ordinal-group)

'Box' is a bit misleading, I think a better choice is
'CSSPropertyAPIFragmentationGroup'. :)

[nainar, 2017-01-19 00:46:21]

Description was changed from

==========
Implements CSSPropertyAPI for the box element properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWidows, CSSPropertyOrphans and 
CSSPropertyWebkitBoxOrdinalGroup from the switch statement in 
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
border radius properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIBoxGroup.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPIBoxGroup flag to each border class 
  property in CSSProperties.in, which indicates that 
  CSSPropertyAPIBoxGroup.h is generated.
- Moves the parsing logic for border radius from CSSPropertyParser.cpp
  to CSSPropertyAPIBoxGroup.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the fragmentation element properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWidows, CSSPropertyOrphans and 
CSSPropertyWebkitFragmentationOrdinalGroup from the switch statement in 
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
border radius properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIFragmentationGroup.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPIFragmentationGroup flag to each fragmentation
class 
  property in CSSProperties.in, which indicates that 
  CSSPropertyAPIFragmentationGroup.h is generated.
- Moves the parsing logic for fragmentation properties from
CSSPropertyParser.cpp
  to CSSPropertyAPIFragmentationGroup.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[nainar, 2017-01-19 00:55:24]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:56:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-01-19 00:57:23]

Sasha, 

PTAL? Thanks! :)

https://codereview.chromium.org/2639303004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/BUILD.gn (right):

https://codereview.chromium.org/2639303004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/BUILD.gn:345: "parser/SizesCalcParser.cpp",
On 2017/01/19 at 00:41:59, sashab wrote:
> Typo in CL description in the bullet points bit - each 'box' class :) and then
the parsing logic for 'box properties'

Done. Great catch!

https://codereview.chromium.org/2639303004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBoxGroup.cpp
(right):

https://codereview.chromium.org/2639303004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBoxGroup.cpp:11:
const CSSValue* CSSPropertyAPIBoxGroup::parseSingleValue(
Done

[sashab, 2017-01-19 01:01:45]

LGTM conditional on anna liking the name 'CSSPropertyAPIFragmentationGroup'. Is
the convention to have 'Group' at the end of the name? :)

Also well done naina :D

[nainar, 2017-01-19 01:49:52]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 01:50:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-01-19 01:50:38]

Yup talked to Anna and she prefers CSSPropertyAPIFragmentation as well so
changed that. Landing now

[nainar, 2017-01-19 01:50:41]

The CQ bit was unchecked by nainar@chromium.org

[nainar, 2017-01-19 01:50:48]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-01-19 01:50:48]

The patchset sent to the CQ was uploaded after l-g-t-m from aazzam@google.com,
sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2639303004/#ps80001
(title: "FragmentationGroup -> Fragmentation")

[commit-bot: I haz the power, 2017-01-19 01:51:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 03:40:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 03:40:18]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[nainar, 2017-01-19 03:59:03]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2017-01-19 03:59:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 04:06:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 04:06:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nainar, 2017-03-13 00:55:29]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 00:55:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 02:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 02:42:08]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-03-13 03:07:04]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-03-13 03:07:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
aazzam@google.com
Link to the patchset: https://codereview.chromium.org/2639303004/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-13 03:07:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 03:11:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489374424997130,
"parent_rev": "56b97e3cfe95c1edbb7e14bd92f6fbc7692745e6", "commit_rev":
"b5e82dce09c880f7aa92a7a2203dc4b0e64c0e84"}

[commit-bot: I haz the power, 2017-03-13 03:13:05]

Description was changed from

==========
Implements CSSPropertyAPI for the fragmentation element properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWidows, CSSPropertyOrphans and 
CSSPropertyWebkitFragmentationOrdinalGroup from the switch statement in 
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
border radius properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIFragmentationGroup.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPIFragmentationGroup flag to each fragmentation
class 
  property in CSSProperties.in, which indicates that 
  CSSPropertyAPIFragmentationGroup.h is generated.
- Moves the parsing logic for fragmentation properties from
CSSPropertyParser.cpp
  to CSSPropertyAPIFragmentationGroup.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the fragmentation element properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWidows, CSSPropertyOrphans and 
CSSPropertyWebkitFragmentationOrdinalGroup from the switch statement in 
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
border radius properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIFragmentationGroup.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPIFragmentationGroup flag to each fragmentation
class 
  property in CSSProperties.in, which indicates that 
  CSSPropertyAPIFragmentationGroup.h is generated.
- Moves the parsing logic for fragmentation properties from
CSSPropertyParser.cpp
  to CSSPropertyAPIFragmentationGroup.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2639303004
Cr-Commit-Position: refs/heads/master@{#456320}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5e82dce09c880f7aa92a7a2203d...
==========

[commit-bot: I haz the power, 2017-03-13 03:13:06]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/b5e82dce09c880f7aa92a7a2203d...