cc: Use SkCreateColorSpaceXformCanvas for color transforms

cc: Use SkCreateColorSpaceXformCanvas for color transforms

Add SkCreateColorSpaceXformCanvas, commented out, in RasterSource.

Remove accessors for SkColorSpace and mechanisms for using
kNonLinearBlending_ColorSpaceFlag.

BUG=701942
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2752523006
Cr-Commit-Position: refs/heads/master@{#457630}
Committed: https://chromium.googlesource.com/chromium/src/+/1f9a36662a7b695f5d9d3023ad2be013901ebba3

[ccameron, 2017-03-15 20:02:44]

Description was changed from

==========
cc: Use SkCreateColorSpaceXformCanvas for color transforms

BUG=
==========

to

==========
cc: Use SkCreateColorSpaceXformCanvas for color transforms

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-03-15 20:16:09]

Description was changed from

==========
cc: Use SkCreateColorSpaceXformCanvas for color transforms

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Use SkCreateColorSpaceXformCanvas for color transforms

BUG=701942
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-03-15 20:20:54]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:21:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-03-15 20:22:30]

Description was changed from

==========
cc: Use SkCreateColorSpaceXformCanvas for color transforms

BUG=701942
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Use SkCreateColorSpaceXformCanvas for color transforms

Add SkCreateColorSpaceXformCanvas, commented out, in RasterSource.

Remove accessors for SkColorSpace and mechanisms for using
kNonLinearBlending_ColorSpaceFlag.

BUG=701942
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-03-15 20:22:30]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-03-15 20:29:36]

What has been will be again...

[commit-bot: I haz the power, 2017-03-15 21:24:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:24:07]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-03-15 22:15:40]

https://codereview.chromium.org/2752523006/diff/40001/cc/playback/raster_sour...
File cc/playback/raster_source.h (right):

https://codereview.chromium.org/2752523006/diff/40001/cc/playback/raster_sour...
cc/playback/raster_source.h:48: gfx::ColorSpace target_color_space;
Maybe I'm missing something, but would it make sense to hoist this up to the
caller of RasterSource that passes in the SkCanvas to just pass in the color
space canvas? The RasterSource doesn't have a color space itself, it's rastered
onto a canvas with a target color space, right?

[ccameron, 2017-03-16 05:11:34]

Updated!

https://codereview.chromium.org/2752523006/diff/40001/cc/playback/raster_sour...
File cc/playback/raster_source.h (right):

https://codereview.chromium.org/2752523006/diff/40001/cc/playback/raster_sour...
cc/playback/raster_source.h:48: gfx::ColorSpace target_color_space;
On 2017/03/15 22:15:40, enne wrote:
> Maybe I'm missing something, but would it make sense to hoist this up to the
> caller of RasterSource that passes in the SkCanvas to just pass in the color
> space canvas? The RasterSource doesn't have a color space itself, it's
rastered
> onto a canvas with a target color space, right?

That makes a lot of sense -- we can then the color space directly from the
resource. I've re-shifted things to do this.

[enne (OOO), 2017-03-16 18:20:57]

lgtm

https://codereview.chromium.org/2752523006/diff/60001/cc/playback/raster_sour...
File cc/playback/raster_source.h (right):

https://codereview.chromium.org/2752523006/diff/60001/cc/playback/raster_sour...
cc/playback/raster_source.h:48: gfx::ColorSpace target_color_space;
Unused?

[ccameron, 2017-03-16 19:05:28]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 19:06:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 20:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 20:33:29]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-03-16 21:14:50]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:15:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-03-16 21:16:15]

Thanks!

https://codereview.chromium.org/2752523006/diff/60001/cc/playback/raster_sour...
File cc/playback/raster_source.h (right):

https://codereview.chromium.org/2752523006/diff/60001/cc/playback/raster_sour...
cc/playback/raster_source.h:48: gfx::ColorSpace target_color_space;
On 2017/03/16 18:20:57, enne wrote:
> Unused?

Oop. Yup, thats gone.

[ccameron, 2017-03-16 21:16:21]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2017-03-16 21:16:26]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-03-16 21:16:27]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2752523006/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-16 21:16:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 22:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 22:33:28]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ccameron, 2017-03-16 23:37:55]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-03-16 23:38:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 00:43:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489707475594260,
"parent_rev": "05e316e960818110e3c1378c75cedb6372fd2792", "commit_rev":
"1f9a36662a7b695f5d9d3023ad2be013901ebba3"}

[commit-bot: I haz the power, 2017-03-17 00:44:14]

Description was changed from

==========
cc: Use SkCreateColorSpaceXformCanvas for color transforms

Add SkCreateColorSpaceXformCanvas, commented out, in RasterSource.

Remove accessors for SkColorSpace and mechanisms for using
kNonLinearBlending_ColorSpaceFlag.

BUG=701942
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Use SkCreateColorSpaceXformCanvas for color transforms

Add SkCreateColorSpaceXformCanvas, commented out, in RasterSource.

Remove accessors for SkColorSpace and mechanisms for using
kNonLinearBlending_ColorSpaceFlag.

BUG=701942
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2752523006
Cr-Commit-Position: refs/heads/master@{#457630}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f9a36662a7b695f5d9d3023ad2b...
==========

[commit-bot: I haz the power, 2017-03-17 00:44:15]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/1f9a36662a7b695f5d9d3023ad2b...