cc: Use SkCreateColorSpaceXformCanvas for color transforms

cc/playback/raster_source.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_PLAYBACK_RASTER_SOURCE_H_
 #define CC_PLAYBACK_RASTER_SOURCE_H_
 
 #include <stddef.h>
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "cc/base/cc_export.h"
 #include "cc/debug/rendering_stats_instrumentation.h"
 #include "cc/playback/image_id.h"
 #include "cc/playback/recording_source.h"
 #include "skia/ext/analysis_canvas.h"
 #include "third_party/skia/include/core/SkPicture.h"
+#include "ui/gfx/color_space.h"
 
 namespace cc {
 class DisplayItemList;
 class DrawImage;
 class ImageDecodeCache;
 
 class CC_EXPORT RasterSource : public base::RefCountedThreadSafe<RasterSource> {
  public:
   struct CC_EXPORT PlaybackSettings {
     PlaybackSettings();
     PlaybackSettings(const PlaybackSettings&);
     PlaybackSettings(PlaybackSettings&&);
     ~PlaybackSettings();
 
     // If set to true, this indicates that the canvas has already been
     // rasterized into. This means that the canvas cannot be cleared safely.
     bool playback_to_shared_canvas;
 
     // If set to true, none of the images will be rasterized.
     bool skip_images;
 
     // If set to true, we will use an image hijack canvas, which enables
     // compositor image caching.
     bool use_image_hijack_canvas;
 
+    // If set, use a SkColorSpaceXformCanvas to specify a transform all inputs
+    // to this color space.
+    gfx::ColorSpace target_color_space;

[enne (OOO), 2017/03/15 22:15:40]

Maybe I'm missing something, but would it make sense to hoist this up to the
caller of RasterSource that passes in the SkCanvas to just pass in the color
space canvas? The RasterSource doesn't have a color space itself, it's rastered
onto a canvas with a target color space, right?

[ccameron, 2017/03/16 05:11:34]

That makes a lot of sense -- we can then the color space directly from the
resource. I've re-shifted things to do this.

+
     // If non-empty, an image hijack canvas will be used to skip these images
     // during raster.
     // TODO(khushalsagar): Consolidate more settings for playback here? See
     // crbug.com/691076.
     ImageIdFlatSet images_to_skip;
   };
 
   static scoped_refptr<RasterSource> CreateFromRecordingSource(
       const RecordingSource* other,
       bool can_use_lcd_text);
@@ skipping 89 matching lines @@
   const gfx::Rect recorded_viewport_;
   const gfx::Size size_;
   const bool clear_canvas_with_debug_color_;
   const int slow_down_raster_scale_factor_for_debug_;
 
   // In practice, this is only set once before raster begins, so it's ok with
   // respect to threading.
   ImageDecodeCache* image_decode_cache_;
 
  private:
-  void RasterCommon(SkCanvas* canvas, SkPicture::AbortCallback* callback) const;
+  void RasterCommon(SkCanvas* canvas,
+                    const gfx::ColorSpace& target_color_space,
+                    SkPicture::AbortCallback* callback) const;
 
   void PrepareForPlaybackToCanvas(SkCanvas* canvas) const;
 
   DISALLOW_COPY_AND_ASSIGN(RasterSource);
 };
 
 }  // namespace cc
 
 #endif  // CC_PLAYBACK_RASTER_SOURCE_H_