Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2752523004: Reland of Check incognito profile appropriately on iOS (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
sdefresne, sfiera
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Check incognito profile appropriately on iOS (patchset #1 id:1 of https://codereview.chromium.org/2755483004/ ) Reason for revert: Relanding because the revert didn't fix the problem Original issue's description: > Revert of Check incognito profile appropriately on iOS (patchset #1 id:1 of https://codereview.chromium.org/2747143003/ ) > > Reason for revert: > Speculative revert to see if it affects sizes result, will reland if reverting doesn't help > > Original issue's description: > > Check incognito profile appropriately on iOS > > > > Review-Url: https://codereview.chromium.org/2747143003 > > Cr-Commit-Position: refs/heads/master@{#456762} > > Committed: https://chromium.googlesource.com/chromium/src/+/b6639511f1ed3bd8976ecc9790858cec9a10793f > > TBR=sdefresne@chromium.org,sfiera@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2755483004 > Cr-Commit-Position: refs/heads/master@{#456839} > Committed: https://chromium.googlesource.com/chromium/src/+/7f1e72d80a08c9ea488709193334ccbc0b4188f1 TBR=sdefresne@chromium.org,sfiera@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2752523004 Cr-Commit-Position: refs/heads/master@{#456891} Committed: https://chromium.googlesource.com/chromium/src/+/f54e53e1f9c7e353276485af8d733f367a1bf7b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
qyearsley
Created Reland of Check incognito profile appropriately on iOS
3 years, 9 months ago (2017-03-14 23:22:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752523004/1
3 years, 9 months ago (2017-03-14 23:22:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f54e53e1f9c7e353276485af8d733f367a1bf7b2
3 years, 9 months ago (2017-03-14 23:35:01 UTC) #6
sfiera
3 years, 9 months ago (2017-03-15 09:57:51 UTC) #7
Message was sent while issue was closed.
LGTM; Thanks for handling the reland.

Powered by Google App Engine
This is Rietveld 408576698