Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2747143003:
Check incognito profile appropriately on iOS (Closed)
|
Created:
3 years, 9 months ago by sfiera Modified:
3 years, 9 months ago Reviewers:
sdefresne CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCheck incognito profile appropriately on iOS
Review-Url: https://codereview.chromium.org/2747143003
Cr-Commit-Position: refs/heads/master@{#456762}
Committed: https://chromium.googlesource.com/chromium/src/+/b6639511f1ed3bd8976ecc9790858cec9a10793f
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by sfiera@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Check ingognito profile appropriately on iOS ========== to ========== Check incognito profile appropriately on iOS ==========
sfiera@chromium.org changed reviewers: + sdefresne@chromium.org
Overdue follow-up to https://crrev.com/2645453003
lgtm
The CQ bit was checked by sfiera@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489513308456030, "parent_rev":
"eacc38c7d843ef2d60597070557ce015c451d616", "commit_rev":
"b6639511f1ed3bd8976ecc9790858cec9a10793f"}
Message was sent while issue was closed.
Description was changed from ========== Check incognito profile appropriately on iOS ========== to ========== Check incognito profile appropriately on iOS Review-Url: https://codereview.chromium.org/2747143003 Cr-Commit-Position: refs/heads/master@{#456762} Committed: https://chromium.googlesource.com/chromium/src/+/b6639511f1ed3bd8976ecc979085... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b6639511f1ed3bd8976ecc979085...
Message was sent while issue was closed.
On 2017/03/14 at 18:06:35, commit-bot wrote: > Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b6639511f1ed3bd8976ecc979085... Hi! Around the time of this CL, the number of static initializers decreased On Linux x64: https://build.chromium.org/p/chromium/builders/Linux%20x64 Before: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F3... ... # ic.cc std::ios_base::Init::Init()@plt # ic.cc std::__ioinit [#includes <iostream>, use <ostream> instead] # ic.cc __cxa_atexit@plt [registers a dtor to run at exit] # ic.cc __dso_handle # ic.cc __init_array_end+0x9b8 ... After: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F3... ... # ic.cc std::ios_base::Init::Init()@plt # ic.cc std::__ioinit [#includes <iostream>, use <ostream> instead] # ic.cc __cxa_atexit@plt [registers a dtor to run at exit] # ic.cc __dso_handle ... Do you know if that could possibly be because of this CL? (Just asking because I'm wondering what the cause is; anyway I think decreasing the number of static initializers is supposed to be good.)
Message was sent while issue was closed.
On 2017/03/14 at 19:10:41, qyearsley wrote: > On 2017/03/14 at 18:06:35, commit-bot wrote: > > Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b6639511f1ed3bd8976ecc979085... > > Hi! Around the time of this CL, the number of static initializers decreased On Linux x64: > https://build.chromium.org/p/chromium/builders/Linux%20x64 > > Before: > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F3... > > ... > # ic.cc std::ios_base::Init::Init()@plt > # ic.cc std::__ioinit [#includes <iostream>, use <ostream> instead] > # ic.cc __cxa_atexit@plt [registers a dtor to run at exit] > # ic.cc __dso_handle > # ic.cc __init_array_end+0x9b8 > ... > > After: > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F3... > > ... > # ic.cc std::ios_base::Init::Init()@plt > # ic.cc std::__ioinit [#includes <iostream>, use <ostream> instead] > # ic.cc __cxa_atexit@plt [registers a dtor to run at exit] > # ic.cc __dso_handle > ... > > Do you know if that could possibly be because of this CL? > (Just asking because I'm wondering what the cause is; anyway I think decreasing the number of static initializers is supposed to be good.) Actually, looking at the sizes.py output, I'm now confused, since it says that the number of files with static initializers was supposed to be 7 and now it's 8. I'm not sure what changed, and I'm not sure what to try next; would you mind if we tried speculatively reverting this and then relanding if it doesn't fix the sizes step redness?
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2755483004/ by qyearsley@chromium.org. The reason for reverting is: Speculative revert to see if it affects sizes result, will reland if reverting doesn't help. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
