Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2752463003: Dump and archive symbols for AlertNotificationService.xpc. (Closed)

Created:
3 years, 9 months ago by Robert Sesek
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, Miguel Garcia
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dump and archive symbols for AlertNotificationService.xpc. BUG=699607 Review-Url: https://codereview.chromium.org/2752463003 Cr-Commit-Position: refs/heads/master@{#456717} Committed: https://chromium.googlesource.com/chromium/src/+/468ad4ae0a9db367078f425f97bfc72d6be77abc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/BUILD.gn View 4 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Robert Sesek
3 years, 9 months ago (2017-03-14 14:50:28 UTC) #2
Nico
lgtm It'd be cool if just adding the deps was enough and that could push ...
3 years, 9 months ago (2017-03-14 14:59:04 UTC) #5
Robert Sesek
On 2017/03/14 14:59:04, Nico wrote: > lgtm > > It'd be cool if just adding ...
3 years, 9 months ago (2017-03-14 15:09:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752463003/1
3 years, 9 months ago (2017-03-14 15:32:37 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 16:07:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/468ad4ae0a9db367078f425f97bf...

Powered by Google App Engine
This is Rietveld 408576698